Unused packages: check class existence before actual usage to avoid irrecoverable exceptions (#92)

Slamdunk · web-flow · commit 0b2fcb5bd5ff · 2026-01-27T10:30:54.000+01:00
diff --git a/composer.json b/composer.json
@@ -32,7 +32,7 @@
         "laminas/laminas-validator": "^2.65.0",
         "phpstan/phpstan-deprecation-rules": "^2.0.3",
         "phpstan/phpstan-phpunit": "^2.0.12",
-        "phpunit/phpunit": "^11.5.49",
+        "phpunit/phpunit": "^11.5.50",
         "slam/php-cs-fixer-extensions": "^3.14.0"
     },
     "conflict": {
diff --git a/src/Type/Laminas/ControllerPluginClassReflectionExtension.php b/src/Type/Laminas/ControllerPluginClassReflectionExtension.php
@@ -22,7 +22,10 @@ public function __construct(
 
     public function hasMethod(ClassReflection $classReflection, string $methodName): bool
     {
-        return $classReflection->isSubclassOfClass($this->reflectionProvider->getClass(AbstractController::class)) && $this->getControllerPluginManager()->has($methodName);
+        return
+            $this->reflectionProvider->hasClass(AbstractController::class)
+            && $classReflection->isSubclassOfClass($this->reflectionProvider->getClass(AbstractController::class))
+            && $this->getControllerPluginManager()->has($methodName);
     }
 
     public function getMethod(ClassReflection $classReflection, string $methodName): MethodReflection
diff --git a/src/Type/Laminas/StdlibAbstractOptionsPropertiesClassReflectionExtension.php b/src/Type/Laminas/StdlibAbstractOptionsPropertiesClassReflectionExtension.php
@@ -20,7 +20,10 @@ public function __construct(
 
     public function hasProperty(ClassReflection $classReflection, string $propertyName): bool
     {
-        return $classReflection->isSubclassOfClass($this->reflectionProvider->getClass(AbstractOptions::class)) && $classReflection->hasNativeMethod($this->getGetterName($propertyName));
+        return
+            $this->reflectionProvider->hasClass(AbstractOptions::class)
+            && $classReflection->isSubclassOfClass($this->reflectionProvider->getClass(AbstractOptions::class))
+            && $classReflection->hasNativeMethod($this->getGetterName($propertyName));
     }
 
     public function getProperty(ClassReflection $classReflection, string $propertyName): PropertyReflection

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,10 @@ public function __construct(`
`22`	`22`
`23`	`23`	`public function hasMethod(ClassReflection $classReflection, string $methodName): bool`
`24`	`24`	`{`
`25`		`- return $classReflection->isSubclassOfClass($this->reflectionProvider->getClass(AbstractController::class)) && $this->getControllerPluginManager()->has($methodName);`
	`25`	`+ return`
	`26`	`+ $this->reflectionProvider->hasClass(AbstractController::class)`
	`27`	`+ && $classReflection->isSubclassOfClass($this->reflectionProvider->getClass(AbstractController::class))`
	`28`	`+ && $this->getControllerPluginManager()->has($methodName);`
`26`	`29`	`}`
`27`	`30`
`28`	`31`	`public function getMethod(ClassReflection $classReflection, string $methodName): MethodReflection`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,10 @@ public function __construct(`
`20`	`20`
`21`	`21`	`public function hasProperty(ClassReflection $classReflection, string $propertyName): bool`
`22`	`22`	`{`
`23`		`- return $classReflection->isSubclassOfClass($this->reflectionProvider->getClass(AbstractOptions::class)) && $classReflection->hasNativeMethod($this->getGetterName($propertyName));`
	`23`	`+ return`
	`24`	`+ $this->reflectionProvider->hasClass(AbstractOptions::class)`
	`25`	`+ && $classReflection->isSubclassOfClass($this->reflectionProvider->getClass(AbstractOptions::class))`
	`26`	`+ && $classReflection->hasNativeMethod($this->getGetterName($propertyName));`
`24`	`27`	`}`
`25`	`28`
`26`	`29`	`public function getProperty(ClassReflection $classReflection, string $propertyName): PropertyReflection`