Skip to content

Commit 1458c11

Browse files
committed
Don't REQUIRED in find_dependency.
`find_dependency` exists to wire up the `REQUIRED`-ness from callers. That is, `find_package(coinbase-advanced-cpp QUIET)` needs to `QUIET`-ly return "not available" if `nlohmann_json` is missing, but adding the `REQUIRED` here makes that fail. For more information, see https://cmake.org/cmake/help/latest/module/CMakeFindDependencyMacro.html Drive-by: Fix the version number of slick-net to match. GPT 5.4 discovered the version number mismatch problem in microsoft/vcpkg#52259 but it did neither wrote this message nor made this change.
1 parent f96d2b8 commit 1458c11

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

cmake/coinbase-advanced-cppConfig.cmake.in

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
include(CMakeFindDependencyMacro)
44

5-
find_dependency(nlohmann_json CONFIG REQUIRED)
6-
find_dependency(OpenSSL CONFIG REQUIRED)
7-
find_dependency(jwt-cpp CONFIG REQUIRED)
8-
find_dependency(slick-net 1.2.4 CONFIG QUIET)
5+
find_dependency(nlohmann_json CONFIG)
6+
find_dependency(OpenSSL CONFIG)
7+
find_dependency(jwt-cpp CONFIG)
8+
find_dependency(slick-net 2.1.0 CONFIG)
99

1010
if(NOT slick-net_FOUND)
1111
message(STATUS "Fetching slick-net...")
@@ -15,7 +15,7 @@ if(NOT slick-net_FOUND)
1515
FetchContent_Declare(
1616
slick-net
1717
GIT_REPOSITORY https://github.com/SlickQuant/slick-net.git
18-
GIT_TAG v1.2.4
18+
GIT_TAG v2.1.0
1919
)
2020
FetchContent_MakeAvailable(slick-net)
2121
endif()

0 commit comments

Comments
 (0)