Commit 1458c11
committed
Don't
`find_dependency` exists to wire up the `REQUIRED`-ness from callers. That is, `find_package(coinbase-advanced-cpp QUIET)` needs to `QUIET`-ly return "not available" if `nlohmann_json` is missing, but adding the `REQUIRED` here makes that fail.
For more information, see https://cmake.org/cmake/help/latest/module/CMakeFindDependencyMacro.html
Drive-by: Fix the version number of slick-net to match.
GPT 5.4 discovered the version number mismatch problem in microsoft/vcpkg#52259 but it did neither wrote this message nor made this change.REQUIRED in find_dependency.1 parent f96d2b8 commit 1458c11
1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
0 commit comments