Skip to content

Commit 62e85ab

Browse files
committed
Update CI configuration and enhance websocket test callbacks with override specifier
1 parent 9b0fe6b commit 62e85ab

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,4 +86,4 @@ jobs:
8686
run: cmake --build build --config ${{ matrix.build_type }} -j 4
8787

8888
- name: Test
89-
run: ctest --test-dir build -C ${{ matrix.build_type }} -E "(Order|Fill)" --output-on-failure
89+
run: ctest --test-dir build -C ${{ matrix.build_type }} -E "(Order|Fill|Portfolio)" --output-on-failure

tests/rest_awaitable_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class CoinbaseAwaitableTest : public ::testing::Test {
5454

5555
// Helper to run an async coroutine and wait for result
5656
template<typename Func>
57-
auto run_async(Func&& coro) {
57+
typename std::invoke_result_t<Func>::value_type run_async(Func&& coro) {
5858
using awaitable_type = std::invoke_result_t<Func>;
5959
using result_type = typename awaitable_type::value_type;
6060

tests/websocket_tests.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,21 @@ namespace coinbase::tests {
4545
std::remove("coinbase.log");
4646
}
4747

48-
void onMarketDataConnected(WebSocketClient *) {
48+
void onMarketDataConnected(WebSocketClient *) override {
4949
++md_connected_count_;
5050
LOG_INFO("MarketData Connected");
5151
}
5252

53-
void onMarketDataDisconnected(WebSocketClient *) {
53+
void onMarketDataDisconnected(WebSocketClient *) override {
5454
++md_disconnected_count_;
5555
LOG_INFO("MarketData Disconnected");
5656
}
5757

58-
void onUserDataConnected(WebSocketClient *) {
58+
void onUserDataConnected(WebSocketClient *) override {
5959
LOG_INFO("UserData Connected");
6060
}
6161

62-
void onUserDataDisconnected(WebSocketClient *) {
62+
void onUserDataDisconnected(WebSocketClient *) override {
6363
LOG_INFO("UserData Disconnected");
6464
}
6565

0 commit comments

Comments
 (0)