Skip to content

Scope advanced parameters to selected endpoint (#1074)#1075

Merged
cugarteblair merged 1 commit into
mainfrom
issue-1074-scope-advanced-params
May 28, 2026
Merged

Scope advanced parameters to selected endpoint (#1074)#1075
cugarteblair merged 1 commit into
mainfrom
issue-1074-scope-advanced-params

Conversation

@cugarteblair

@cugarteblair cugarteblair commented May 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Hide Advanced Options panels that the selected endpoint ignores, eliminating misleading controls
  • X-series endpoints (atl06x, atl08x, atl24x, atl13x) read pre-computed segments from HDF5 products; the server discards photon-processing parameters for these endpoints. Verified directly against Atl06Parameters etc. in the sliderule server repo
  • For atl06x and atl08x, the Extents panel now shows the real segment dimensions baked into the data product (len=40m/res=20m for ATL06; len=100m/res=100m for ATL08) as a disabled read-only display with a lock icon and tooltip
  • Request builder gates photon-processing params (fit, len, res, cnf, srt, yapc, atl08_class, pass_invalid, ats, cnt, dist_in_seg) behind an isPhotonAPI check so stale store state doesn't leak into the request

Panel visibility by endpoint

Endpoint Photon Selection Extents Surface Elevation PhoREAL
atl03x variants, atl06p, atl06sp, atl08p, atl03vp editable editable if applicable if applicable
atl06x hidden read-only: 40m / 20m hidden n/a
atl08x hidden read-only: 100m / 100m n/a hidden
atl24x, atl13x hidden hidden n/a n/a

Closes #1074

Test plan

  • make typecheck — no new errors (pre-existing deck3DConfigStore.ts TS2742 warning exists on main, unrelated)
  • make lint — completes with no errors (takes 1–2 minutes; only emits a flat-config deprecation warning unrelated to this PR)
  • make test-unit — 194 passing including new tests/unit/endpointParamScoping.spec.ts (13 cases covering X-series exclusions, P-series inclusions, endpoint-specific params, universal params)
  • In Advanced mode, switch through each endpoint and verify panels appear/disappear as in the table above
  • For atl06x / atl08x, expand Extents and confirm the fixed dimensions display with the lock-icon tooltip
  • Open the request Edit dialog for each X-series endpoint; confirm the JSON has no photon-processing params

🤖 Generated with Claude Code

X-series endpoints (atl06x, atl08x, atl24x, atl13x) read pre-computed
segments from HDF5 products and ignore photon-processing parameters on
the server. The Advanced Options sidebar now hides panels that would be
ignored, and shows the real ATL06/ATL08 segment dimensions disabled for
atl06x/atl08x. Request building skips photon-processing params for these
endpoints to avoid sending values the server discards.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@cugarteblair
cugarteblair merged commit 0d7bb88 into main May 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scrub Advanced parameters exposed to the endpoints and only show ones that are used by the selected endpoint

1 participant