Skip to content

Fix TS2742 typecheck failure in deck3DConfigStore #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cugarteblair merged 1 commit into from
Jun 9, 2026
Merged

Fix TS2742 typecheck failure in deck3DConfigStore #1080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion web-client/src/stores/deck3DConfigStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,19 @@ import { defineStore } from 'pinia'
import { ref, reactive } from 'vue'
import type { OrbitViewState } from '@deck.gl/core'

// Portable shape for the live orbit view state we expose from this store.
// We intentionally do NOT use OrbitViewState as the reactive() generic: reactive()
// unwraps it structurally, which drags in @deck.gl/core's internal (non-exported)
// transitions/transition type and trips TS2742 on the store's inferred public type.
// OrbitViewState is still fine as a parameter type below since it's referenced by
// its public name, not structurally expanded.
interface Deck3DViewState {
target: number[]
zoom: number
rotationX: number
rotationOrbit: number
}

export const useDeck3DConfigStore = defineStore('deckConfig', () => {
const deckContainer = ref<HTMLDivElement | null>(null)

Expand Down Expand Up @@ -41,7 +54,7 @@ export const useDeck3DConfigStore = defineStore('deckConfig', () => {
const hoverMarkerScale = ref(2.0) // User-adjustable scale factor (percentage of data extent)
// — LIVE VIEW STATE —
// these will be updated in onViewStateChange
const viewState = reactive<OrbitViewState>({
const viewState = reactive<Deck3DViewState>({
target: [...centroid.value],
zoom: 5,
rotationX: 45,
Expand Down
Loading