Fix atl24x photon-cloud overlay version handling (#1084)#1085
Merged
Conversation
The ATL24 photon-cloud overlay re-fetches an atl03x request with atl24 classification, deriving the source ATL03 granule name and CMR version from the parent ATL24 product. The CMR version was hardcoded to '006', so it could not track the ATL24 product's input ATL03 release. - Derive cmr.version from the derived resource name's version field (VVV) instead of hardcoding '006', so the overlay follows the ATL24 product (e.g. automatically uses '007' once the R007-based ATL24 run ships). - Color an atl24x overlay by atl24_class by passing the real parent func string, and fall back to atl03x in getDefaultColorEncoding before the rec tree updates (removes a spurious "No function found for reqId" warning). Note: this does not restore the photon cloud on its own. The current ATL24 product was built from ATL03 R006, which NSIDC removed from S3; full resolution depends on R006 being restored or the R007-based ATL24 run (summer 2026). See issue #1084. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Client-side follow-ups for the
atl24xphoton-cloud overlay (issue #1084).The overlay re-fetches an
atl03xrequest withatl24classification, deriving the source ATL03 granule name and CMR version from the parent ATL24 product (whose granule name encodes the input ATL03 release per NSIDC ATL24 User Guide §1.2.3).Changes
reqParamsStore.ts— derivecmr.versionfrom the derived resource name's version field (ATL03_[date]_[ttttccss]_[VVV]_[RR].h5) instead of hardcoding"006". The overlay now tracks the ATL24 product automatically, so when the R007-based ATL24 run ships the request uses"007"with no code change.SrElevationPlot.vue/plotUtils.ts— color anatl24xoverlay byatl24_class(pass the real parent func string rather than a hardcoded"atl03x"), and fall back toatl03xingetDefaultColorEncodingwhile the rec tree hasn't yet registered the freshly-created overlay node — removing a spuriousNo function found for reqId, returning solid color encodingwarning.Important: this does not restore the photon cloud by itself
The current ATL24 product was built from ATL03 R006, and NSIDC removed the R006 ATL03 granules from S3 that SlideRule reads, so the overlay returns
NO_DATAregardless of these changes. Confirmed external (not a client bug) by the SlideRule server developer (JP Swinski). Full resolution depends on:cmr.versionderivation above picks up"007"automatically.Refs #1084 — leaving the issue open to track the external resolution.
Testing
make typecheck✅make lint✅🤖 Generated with Claude Code