Treat atl06sp as a subsetter, not photon-processing#1086
Merged
Conversation
atl06sp is the parallel ATL06 subsetter — its server schema is Atl06Parameters (the minimal class, same as atl06x), and it calls the atl06s runner which reads pre-computed ATL06 segments from the source HDF5 product. PR #1075 mistakenly classified it as photon-processing. - Remove atl06sp from photonProcessingAPIs - Show the read-only Extents display (40m / 20m, same as atl06x) for atl06sp - Hide Surface Elevation panel for atl06sp (fit is applied during product gen) - Generalize tests + comments from "X-series" to "subsetter endpoints"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fix to PR #1075 (issue #1074).
atl06spis the parallel ATL06 subsetter, not a photon-processing endpoint. Its server schema isAtl06Parameters(the minimal class, same asatl06x), and its main callsproxy.proxy(resources, parms, "atl06s", ...)— running theatl06srunner which reads pre-computed ATL06 segments from the source HDF5 product. The asset isicesat2-atl06, noticesat2.PR #1075 mistakenly grouped
atl06spwithatl06p. This corrects that:atl06spfromphotonProcessingAPIsso photon-processing params aren't sent in the request40m / 20m, same asatl06x) foratl06spatl06sp(fit was applied during ATL06 product generation)atl06sptest case covering bothatl06_fieldsand the correcticesat2-atl06assetatl06sp+ the X-series)Updated panel visibility by endpoint
atl03xvariants,atl06p,atl08p,atl03vpatl06spatl06xatl08xatl24x,atl13xRefs #1074
Test plan
make lintcleanmake test-unit— 196 passing (added 2 new cases:atl06spsubsetter exclusion +atl06spasset/fields test)atl06spand verify: Photon Selection and Surface Elevation are hidden; Extents shows the read-only40m / 20mdisplay;atl06 Fieldseditor still works under Ancillary Fieldsatl06sp; confirm JSON hasasset: "icesat2-atl06", no photon-processing params🤖 Generated with Claude Code