Fix sidebar run button hidden after Home -> Request navigation#1089
Merged
Conversation
LandingView scrolls the persistent .sliderule-content container to center a panel, but nothing restored it afterward, leaving the Request view's sidebar (and its run button) cropped when navigated to directly from Home.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LandingView.vue'sonMountedhook scrolls the shared.sliderule-contentcontainer (owned byApp.vue, persistent across all route navigations) to center a panel/tab.RequestView's sidebar (and its run button) rendered below the fold, cropped by the leftover scroll offset..sliderule-content's scroll, which is why this only reproduced from Home, as confirmed by the reporter.onBeforeUnmounthook inLandingView.vuethat resets.sliderule-contentback to the top before the next view mounts (Vue/vue-router guarantee the outgoing view's unmount hooks run before the incoming view mounts, so there's no race).Fixes #1087
Test plan
make typecheckpasses