debug build fixes

Author: jpswinski

packages/arrow/package/ArrowDataFrame.cpp

@@ -294,11 +294,8 @@ void encodeGeometry(const GeoDataFrame& dataframe, vector<shared_ptr<arrow::Arra
 string geoMetaData (const string& crs)
 {
     if (crs.empty()) throw RunTimeException(CRITICAL, RTE_FAILURE, "CRS is required");
-
-    const string geostr = R"({"version":"1.0.0","primary_column":"geometry","columns":{"geometry":{
+    return R"({"version":"1.0.0","primary_column":"geometry","columns":{"geometry":{
                               "encoding":"WKB","geometry_types":["Point"],"crs":)" + crs + R"(}}})";
-
-    return geostr;
 }
 
 /*----------------------------------------------------------------------------

packages/core/package/GeoDataFrame.cpp

@@ -1937,7 +1937,7 @@ int GeoDataFrame::luaDescribe (lua_State* L)
         const char* description = getLuaString(L, 2);
 
         // get open api string
-        string str = lua_obj->toOpenApi(description);
+        const string str = lua_obj->toOpenApi(description);
 
         // return schema
         lua_pushstring(L, str.c_str());

packages/core/package/LuaEndpoint.cpp

@@ -179,15 +179,15 @@ bool LuaEndpoint::asyncHandler (Request* request, LuaEngine* engine, const endpo
     }
 
     /* Build Receipt */
-    UString response_id; // unique response id
+    const UString response_id; // unique response id
     AlertMonitor alert_mon(NULL, INFO, async_rspq.getName());
     Asset* asset = dynamic_cast<Asset*>(LuaObject::getLuaObjectByName(SystemConfig::settings().stagingAsset.value.c_str(), Asset::OBJECT_TYPE));
     if(!asset) throw RunTimeException(CRITICAL, RTE_FAILURE, "Unable to access staging asset: %s", SystemConfig::settings().stagingAsset.value.c_str());
     const CredentialStore::Credential& credentials = CredentialStore::get(asset->getIdentity());
-    FString receipt_filename("receipt-%s.txt", response_id.c_str());
+    const FString receipt_filename("receipt-%s.txt", response_id.c_str());
 
     /* Send Header and Async Response (as JSON) */
-    FString response("{\"receipt\": \"s3://%s/%s\", \"endpoint\": \"%s\", \"parameters\": %s}", asset->getPath(), receipt_filename.c_str(), request->resource, endpoint.request_parameters->toJson().c_str());
+    const FString response("{\"receipt\": \"s3://%s/%s\", \"endpoint\": \"%s\", \"parameters\": %s}", asset->getPath(), receipt_filename.c_str(), request->resource, endpoint.request_parameters->toJson().c_str());
     sendHeader(OK, content2str(JSON), &request->rspq, response.c_str(), response.size());
 
     /* Terminate Connection */

packages/core/package/StringLib.cpp

@@ -160,15 +160,15 @@ const char* StringLib::UniqueString::c_str(bool duplicate) const
 /*----------------------------------------------------------------------------
  * length - number of non-null characters in string
  *----------------------------------------------------------------------------*/
-long StringLib::UniqueString::length(void) const
+long StringLib::UniqueString::length(void)
 {
     return UUID_STR_LEN - 1; // remove null terminator in length
 }
 
 /*----------------------------------------------------------------------------
  * size - alias for length
  *----------------------------------------------------------------------------*/
-long StringLib::UniqueString::size(void) const
+long StringLib::UniqueString::size(void)
 {
     return length();
 }

packages/core/package/StringLib.h

@@ -73,8 +73,8 @@ class StringLib
                 ~UniqueString (void) = default;
 
                 const char*     c_str       (bool duplicate = false) const;
-                long            length      (void) const;
-                long            size        (void) const;
+                static long     length      (void);
+                static long     size        (void);
 
             private: