Use C++23

Author: ImSapphire

.github/workflows/c-cpp.yml

@@ -31,6 +31,12 @@ jobs:
       with:
         submodules: true
 
+    - if: matrix.os == 'ubuntu-latest'
+      name: Install GCC 16
+      uses: egor-tensin/setup-gcc@v2
+      with:
+        version: 16
+
     - uses: lukka/get-cmake@latest
 
     - name: Get submodule commit hashes

CMakeLists.txt

@@ -108,7 +108,7 @@ file(GLOB_RECURSE SOURCES "${CMAKE_CURRENT_SOURCE_DIR}/src/*.cpp")
 file(GLOB_RECURSE HEADERS "${CMAKE_CURRENT_SOURCE_DIR}/src/*.hpp")
 add_library("${PROJECT_NAME}_static" STATIC ${SOURCES} ${PROTO_HEADER} ${PROTO_SRC})
 target_link_libraries("${PROJECT_NAME}_static" PUBLIC ${DEPS_LIBS})
-set_property(TARGET "${PROJECT_NAME}_static" PROPERTY CXX_STANDARD 20)
+set_property(TARGET "${PROJECT_NAME}_static" PROPERTY CXX_STANDARD 23)
 include_directories("${PROJECT_NAME}_static" PUBLIC ${DEPS_INCLUDES} ${Protobuf_INCLUDE_DIRS} ${CMAKE_CURRENT_BINARY_DIR} "${CMAKE_CURRENT_BINARY_DIR}/src")
 if(UNIX)
     target_compile_options("${PROJECT_NAME}_static" PRIVATE "-fPIC")
@@ -119,15 +119,15 @@ endif()
 file(GLOB_RECURSE DRIVER_MAIN "${CMAKE_CURRENT_SOURCE_DIR}/src/DriverFactory.cpp")
 add_library("${PROJECT_NAME}" SHARED ${DRIVER_MAIN} ${HEADERS} ${PROTO_HEADER})
 target_link_libraries("${PROJECT_NAME}" PUBLIC "${PROJECT_NAME}_static")
-set_property(TARGET "${PROJECT_NAME}" PROPERTY CXX_STANDARD 20)
+set_property(TARGET "${PROJECT_NAME}" PROPERTY CXX_STANDARD 23)
 
 # compile tests
 function(build_tests target_name test_dir)
     file(GLOB TESTS "${CMAKE_CURRENT_SOURCE_DIR}/${test_dir}/*.cpp" "${CMAKE_CURRENT_SOURCE_DIR}/${test_dir}/*.hpp")
     file(GLOB TESTS_COMMON "${CMAKE_CURRENT_SOURCE_DIR}/test/common/*.cpp" "${CMAKE_CURRENT_SOURCE_DIR}/test/common/*.hpp")
     add_executable(${target_name} ${TESTS} ${TESTS_COMMON} ${HEADERS} ${PROTO_HEADER})
     target_link_libraries(${target_name} PUBLIC "${PROJECT_NAME}_static" Catch2::Catch2WithMain)
-    set_property(TARGET ${target_name} PROPERTY CXX_STANDARD 20)
+    set_property(TARGET ${target_name} PROPERTY CXX_STANDARD 23)
 endfunction()
 build_tests(tests "test")
 build_tests(tests_integration "test/integration")

src/VRDriver.cpp

@@ -5,6 +5,7 @@
 #include <TrackerDevice.hpp>
 #include <google/protobuf/arena.h>
 #include <simdjson.h>
+#include <utility>
 
 vr::EVRInitError SlimeVRDriver::VRDriver::Init(vr::IVRDriverContext* pDriverContext) {
     // Perform driver context initialisation
@@ -133,7 +134,7 @@ void SlimeVRDriver::VRDriver::RunPoseRequestThread(std::stop_token stop) {
 
         auto notify_status_changed = [this](DeviceData& device, messages::ProtobufMessage* message, messages::TrackerStatus_Status status) {
             if (device.status != status) {
-                logger_->Log("Status for device {} changing {}->{}", device.index, static_cast<int>(device.status), static_cast<int>(status));
+                logger_->Log("Status for device {} changing {}->{}", device.index, std::to_underlying(device.status), std::to_underlying(status));
                 messages::TrackerStatus* tracker_status = google::protobuf::Arena::Create<messages::TrackerStatus>(&arena_);
                 message->set_allocated_tracker_status(tracker_status);
                 tracker_status->set_tracker_id(device.index);
@@ -342,7 +343,7 @@ void SlimeVRDriver::VRDriver::OnBridgeMessage(const messages::ProtobufMessage& m
             AddDevice(std::make_shared<TrackerDevice>(ta.tracker_serial(), ta.tracker_id(), role));
             break;
         default:
-            logger_->Log("Got tracker added message for unhandled device type {} (role {})", static_cast<unsigned>(GetDeviceType(role)), static_cast<unsigned>(role));
+            logger_->Log("Got tracker added message for unhandled device type {} (role {})", std::to_underlying(GetDeviceType(role)), std::to_underlying(role));
             break;
         }
     } else if (message.has_position()) {

src/bridge/BridgeTransport.cpp

@@ -21,6 +21,7 @@
     THE SOFTWARE.
 */
 #include "BridgeTransport.hpp"
+#include <bit>
 
 void BridgeTransport::Start() {
     thread_ = std::make_unique<std::thread>(&BridgeTransport::RunThread, this);
@@ -83,11 +84,10 @@ void BridgeTransport::OnRecv(const uvw::data_event& event) {
 
         char len_buf[4];
         recv_buf_.Peek(len_buf, 4);
-        uint32_t size = 0;
-        size = static_cast<uint32_t>(static_cast<uint8_t>(len_buf[0])) |      //
-            (static_cast<uint32_t>(static_cast<uint8_t>(len_buf[1])) << 8) |  //
-            (static_cast<uint32_t>(static_cast<uint8_t>(len_buf[2])) << 16) | //
-            (static_cast<uint32_t>(static_cast<uint8_t>(len_buf[3])) << 24);
+        uint32_t size = *reinterpret_cast<uint32_t*>(&len_buf[0]);
+        if constexpr (std::endian::native != std::endian::little) {
+            size = std::byteswap(size);
+        }
 
         if (size > VRBRIDGE_MAX_MESSAGE_SIZE) {
             logger_->Log(