check flatpak runtime dir first#1168
Closed
0chroma wants to merge 1 commit into
Closed
Conversation
0chroma
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
September 18, 2024 14:59
ButterscotchV
approved these changes
Sep 19, 2024
ButterscotchV
added
Priority: Normal
Type: Enhancement
Eirenliel
approved these changes
Oct 11, 2024
Contributor
|
currently discussing where stuff should be on SlimeVR/SlimeVR-OpenVR-Driver#48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change would allow SlimeVR to set up sockets on the host while running in a flatpak. In order to do this, we set the socket dir to
$XDG_RUNTIME_DIR/app/$FLATPAK_IDif theFLATPAK_IDenvironment variable is set.Flatpak's sandbox doesn't allow writes to the runtime root, for more details see: https://docs.flatpak.org/en/latest/sandbox-permissions.html
Related changes: SlimeVR/SlimeVR-OpenVR-Driver#48 and SlimeVR/SlimeVR-Feeder-App#22