Skip to content

Add Velocity calculation logic and GUI toggle (end-to-end MVP).#1753

Open
M1DNYT3 wants to merge 12 commits intoSlimeVR:mainfrom
M1DNYT3:velocity-mvp
Open

Add Velocity calculation logic and GUI toggle (end-to-end MVP).#1753
M1DNYT3 wants to merge 12 commits intoSlimeVR:mainfrom
M1DNYT3:velocity-mvp

Conversation

@M1DNYT3
Copy link
Copy Markdown

@M1DNYT3 M1DNYT3 commented Feb 17, 2026 •
edited
Loading

This PR completes velocity transmission end-to-end, adding RPC settings and a GUI toggle on top of the foundation from #1754.

What's added:

  • Protobuf velocity transmission via ProtobufBridge, per-tracker
  • RPC settings support - toggle persists across restarts
  • GUI toggle in General Settings with i18n

Toggle's GUI Path:
Settings > General > Tracker Settings > Toggle is at the very bottom of the section.

Technicalities:
Most of the line count (~400) comes from regenerated ProtobufMessages.java. The handwritten change itself is small.

Depends on SlimeVR/SolarXR-Protocol#202, should be merged only after the submodule is updated to the tracked HEAD.

Addresses the issue: #25

@github-actions github-actions Bot added Area: Skeletal Model Deals with the model of the skeleton and its pose Area: Server Related to the server labels Feb 17, 2026
@M1DNYT3 M1DNYT3 force-pushed the velocity-mvp branch 3 times, most recently from b502b9c to b83d03d Compare February 17, 2026 12:26
@M1DNYT3
Copy link
Copy Markdown
Author

M1DNYT3 commented Feb 17, 2026

Force pushes in history are changes made by spotless.
For some reason, one application wasn't enough for it to fix all the issues in Tracker.kt, so I had to push it twice, and I didn't want to make 2 separate commits for spotless alone.

@M1DNYT3 M1DNYT3 mentioned this pull request Feb 17, 2026
Closed
@M1DNYT3 M1DNYT3 changed the title MVP. Add Velocity transmission toggle and calculation logic. MVP. Add Velocity calculation toggle and logic. Feb 17, 2026
@M1DNYT3 M1DNYT3 changed the title MVP. Add Velocity calculation toggle and logic. Velocity MVP. Add Velocity calculation toggle and logic. Feb 17, 2026
@M1DNYT3 M1DNYT3 mentioned this pull request Mar 6, 2026
Open
@github-actions github-actions Bot added Area: Application Protocol Related to communication with apps like the GUI, overlay, games Area: GUI Related to the GUI Area: Translation Improvements or additions to translations Area: SteamVR Driver Related to the SteamVR Driver labels Mar 20, 2026
@M1DNYT3 M1DNYT3 mentioned this pull request Mar 20, 2026
Merged
@M1DNYT3
Copy link
Copy Markdown
Author

M1DNYT3 commented Mar 20, 2026 •
edited
Loading

At some point, I had a conversation with @ButterscotchV in DMs, and there was a recommendation expressed to ship the whole feature (Implying a toggle, nothing overkill) in one PR.

The description is edited accordingly to reflect each affected part of the code.
The handwritten part (meaning not regenerated flatbuf, and not regenerated ProtobufMessages) follows the existing code architecture 1:1 and reuses the methods, styles, and classes, where necessary.

@M1DNYT3 M1DNYT3 changed the title Velocity MVP. Add Velocity calculation toggle and logic. Add Velocity calculation logic and GUI toggle (end-to-end MVP). Mar 20, 2026
@M1DNYT3 M1DNYT3 force-pushed the velocity-mvp branch 2 times, most recently from b3df88e to fc9c9a6 Compare April 22, 2026 15:58
@M1DNYT3
Copy link
Copy Markdown
Author

M1DNYT3 commented Apr 22, 2026 •
edited
Loading

I had some additional feedback from @ButterscotchV in DMs, addressed it all + rebased to the latest main + also did some changes of my own.

Feedback changes:

  • drop applyVelocityPolicyTo() in VRServer.kt; initially made for expandability, but turned out to be redundant because VRConfig.applyVelocityPolicy() already covers expandability.
  • replace System.nanoTime() with Kotlin's TimeSource; self-explaining, did precisely that.

My own improvement:
Noticed that I forgot to wire hasVelocity instead of allowVelocity in the ProtobufBridge.kt; the former was created for a safeguard to not send anything if we don't have any velocity in the tracker. Technically, both calls would result in the same behavior, but hasVelocity follows architecture better and explicitly states that there has to be something for it to be sent, whereas allowVelocity simply states whether the toggle is on or off.

ButterscotchV
ButterscotchV requested changes Apr 24, 2026
View reviewed changes
Comment thread server/desktop/src/main/java/dev/slimevr/desktop/platform/ProtobufBridge.kt Outdated
Comment thread server/core/src/main/java/dev/slimevr/config/VRConfig.kt Outdated
Comment thread server/core/src/main/java/dev/slimevr/tracking/trackers/Tracker.kt Outdated
Comment thread server/core/src/main/java/dev/slimevr/tracking/trackers/Tracker.kt Outdated
Comment thread server/core/src/main/java/dev/slimevr/tracking/trackers/Tracker.kt Outdated
@M1DNYT3
Copy link
Copy Markdown
Author

M1DNYT3 commented Apr 24, 2026

Review changes were shipped and tested E2E with SteamVR.

One thing to note. Jitter is still noticeable. I may think of a one-euro filter or some velocity smoothing added, but I suggest that to be a separate PR once this one is shipped.

@M1DNYT3 M1DNYT3 requested a review from ButterscotchV April 24, 2026 11:26
ButterscotchV
ButterscotchV requested changes Apr 24, 2026
View reviewed changes
Comment thread server/core/src/main/java/dev/slimevr/tracking/trackers/Tracker.kt Outdated
Comment thread server/core/src/main/java/dev/slimevr/tracking/trackers/Tracker.kt Outdated
ButterscotchV
ButterscotchV approved these changes Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, SolarXR needs to be merged/fixed before this PR.

@ButterscotchV ButterscotchV added Status: Blocked by other issue Progress cannot be made until linked issue is resolved and removed Status: Blocked by other issue Progress cannot be made until linked issue is resolved labels Apr 24, 2026
ImSapphire
ImSapphire reviewed Apr 27, 2026
View reviewed changes
Comment thread server/core/src/main/java/dev/slimevr/config/VelocityConfig.kt Outdated
Comment thread server/core/src/main/java/dev/slimevr/tracking/trackers/Tracker.kt
M1DNYT3 added 12 commits April 28, 2026 12:13
@M1DNYT3
Add Velocity transmission toggle and calculation logic.
6577987
@M1DNYT3
Add Velocity data send via ProtobufBridge. Update ProtobufMessages to…
15aa4f4 
… latest definition from the Driver's main branch.
@M1DNYT3
Added velocity transmission toggle to GUI and RPC (NaLo support)
369991a
@M1DNYT3
Remove applyVelocityPolicyTo(), Replace System.nanoTime with Timesour…
3a53ccc 
…ce, Replace allowVelocity with hasVelocity in ProtobufBridge.
@M1DNYT3
Add build stubs for solarxr-protocol schema additions pending SlimeVR…
40089e0 
…#1811

# Conflicts:
#	server/core/src/main/java/dev/slimevr/protocol/rpc/settings/RPCSettingsBuilder.kt
@M1DNYT3
Add FBT jitter warning to velocity settings description
3d111ab 
� Conflicts:
�	server/core/src/main/java/dev/slimevr/protocol/rpc/settings/RPCSettingsBuilder.kt
@M1DNYT3
Fix RPC velocity toggle state being sent to response instead of request
6427535
@M1DNYT3
Review: Inlined velocity policy, non-nullable velocityState, markNow …
cfab5bc 
…timing fix, non-nullable writeTrackerUpdate param
@M1DNYT3
Review: velocityState direct use and change to val
c8ad726
@M1DNYT3
Solar: sync with the updated head
c2c6675
@M1DNYT3
Update solarxr to track main.
ec178b6
@M1DNYT3
Review: rename updateTrackersVelocityPolicy and rephrase updateDerive…
76d087e 
…dVelocity KDoc
@M1DNYT3 M1DNYT3 requested a review from ImSapphire April 28, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@ImSapphire ImSapphire ImSapphire approved these changes

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo is a code owner

@loucass003 loucass003 Awaiting requested review from loucass003 loucass003 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Area: Application Protocol Related to communication with apps like the GUI, overlay, games Area: GUI Related to the GUI Area: Server Related to the server Area: Skeletal Model Deals with the model of the skeleton and its pose Area: SteamVR Driver Related to the SteamVR Driver Area: Translation Improvements or additions to translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@M1DNYT3 @ButterscotchV @ImSapphire