Validate sensor calibration files#528
Merged
Merged
Conversation
Add stricter validation when loading sensor calibrations: skip files with unexpected size, warn and skip if the read bytes don't match the expected struct size, and validate the sensorConfig.type value before using it. Initialize SensorConfig to zeros prior to reading. Change FSHelper read/write signatures to return size_t (bytes read/written) instead of bool to accurately reflect I/O results. Used copilot to help
Eirenliel
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change FS I/O
Add stricter validation when loading sensor calibrations: skip files with unexpected size, warn and skip if the read bytes don't match the expected struct size, and validate the sensorConfig.type value before using it. Initialize SensorConfig to zeros prior to reading. Change FSHelper read/write signatures to return size_t (bytes read/written) instead of bool to accurately reflect I/O results.
Used copilot to help