Skip to content

Refactor build.py to improve platformio command resolution and path h…#530

Closed
unlogisch04 wants to merge 1 commit into
mainfrom
fix/cionwindows
Closed

Refactor build.py to improve platformio command resolution and path h…#530
unlogisch04 wants to merge 1 commit into
mainfrom
fix/cionwindows

Conversation

@unlogisch04
Copy link
Copy Markdown
Contributor

…andling

This commit fixes that pio or platformio was not found while running the build.py script on my windows This changes where done by copilot.
Tested by me on Windows and on gh ci not on web build, but this file is not used there so should be ok.

…andling

This commit fixes that pio or platformio was not found while running the build.py script on my windows
This changes where done by copilot.  Tested by me on Windows and on gh ci
@unlogisch04 unlogisch04 requested a review from Eirenliel as a code owner May 31, 2026 16:23
@Eirenliel
Copy link
Copy Markdown
Member

This changes where done by copilot.

i immediately don't trust this code.

@Eirenliel Eirenliel requested review from gorbit99 and loucass003 June 1, 2026 10:09
@unlogisch04
Copy link
Copy Markdown
Contributor Author

Well agree. But im not even sure why the old code did begin to not work on my os.
I have maybe a messed up env path. But also after reinstalling the IDE + Python was not working.
So maybe it is not needed.

@Eirenliel
Copy link
Copy Markdown
Member

Then this is enough to close the issue. Per our old policy AI-generated code is not allowed, per our new policy (pending discussion), you're not allowed to submit code that you don't know how it works.

@Eirenliel Eirenliel closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants