feat: support pods that are owned by deployments#22
Open
cgetzen wants to merge 2 commits into
Open
Conversation
Signed-off-by: Charlie Getzen <charliegetzen@meshy.ai>
Signed-off-by: Charlie Getzen <charliegetzen@meshy.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #21
The deployment example in https://github.com/SlinkyProject/slurm-bridge/blob/main/docs/workload.md#annotations does not work.
Given that Pod is a supported workload, pods owned by deployments should also be supported.
Checklist
CONTRIBUTING.md
and the
Code of Conduct.
Breaking Changes
No breaking changes
Testing Notes
Integration tests have been added for the scheduler, similar to controller and admissions integration tests.
Applying the example from the readme now schedules correctly:
Additional Context