Add QOS types and client interface for v0044#2
Open
faganihajizada wants to merge 1 commit intoSlinkyProject:mainfrom
Open
Add QOS types and client interface for v0044#2faganihajizada wants to merge 1 commit intoSlinkyProject:mainfrom
faganihajizada wants to merge 1 commit intoSlinkyProject:mainfrom
Conversation
faganihajizada
force-pushed
the
feat/qos
branch
from
9bbf5a1 to
53354e4
Compare
Contributor
|
Lacks tests in client_v0044_test.go, and is missing fake client handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add V0044 QOS wrapper types and client interface to support declarative QOS management in the slurm-operator. This enables CRUD operations against the slurmdb QOS REST API endpoints (
/slurmdb/v0.0.44/qos).New files:
pkg/types/V0044Qos.go:V0044Qos/V0044QosListwrapper types (same pattern asV0044ReservationInfo)pkg/client/api/v0044/qos.go:QosInterfacewith Create, Update, Delete, Get, ListModified:
pkg/client/api/v0044/v0044.go: addQosInterfacetoClientInterfacepkg/client/client.go: wireV0044Qos/V0044QosListinto all 5 CRUD type switchesBreaking Changes
N/A
Testing Notes
go test ./pkg/types/ -run V0044Qosgo test ./pkg/client/api/v0044/ -run Qosgo build ./...andgo vet ./...pass cleanAdditional Context
This is a prerequisite for the slurm-operator QOS feature (SlurmQos CRD + controller). The QOS client uses slurmdb endpoints (not slurmctld), and POST is idempotent (create-or-update), which the operator relies on for reconciliation.
PR: SlinkyProject/slurm-operator#158