test(helm): add unit tests for Slurm partitions#161
Closed
giuliocalzo wants to merge 1 commit intoSlinkyProject:mainfrom
Closed
test(helm): add unit tests for Slurm partitions#161giuliocalzo wants to merge 1 commit intoSlinkyProject:mainfrom
giuliocalzo wants to merge 1 commit intoSlinkyProject:mainfrom
Conversation
Add helm-unittest coverage for values.partitions (Controller extraConf) and nodesets.*.partition (NodeSet CR), including invalid partition validation via failedTemplate assertions.
Contributor
|
This has been merged: 6deef84 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds helm-unittest coverage for partition-related Helm values:
values.partitions— lines emitted into the Controller CRspec.extraConf(defaultallpartition, extra partitions,configMap-built options, disabled partitions).failedTemplateassertions when a partition references a missing NodeSet or has an emptynodesetslist.nodesets.*.partition— NodeSet CRspec.partitionfrom rawconfig, fromconfigMap, omitted whenpartitionis null, and defaultenabled: false.Test plan
helm unittest --strict helm/slurm(ormake helm-unittest)