Skip to content

Commit 9595cf6

Browse files
authored
triv: make all fields on Card entity optional (#2)
1 parent f27101e commit 9595cf6

1 file changed

Lines changed: 22 additions & 22 deletions

File tree

lib/Model/Card.php

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,55 +11,55 @@
1111

1212
class Card
1313
{
14-
public string $maskedCardNumber;
15-
public string $cardHolderName;
16-
public string $type;
17-
public string $issuerCountry;
18-
public string $cardToken;
19-
public bool $cardSavingApproved;
20-
public string $expiryMonth;
21-
public string $expiryYear;
14+
public ?string $maskedCardNumber;
15+
public ?string $cardHolderName;
16+
public ?string $type;
17+
public ?string $issuerCountry;
18+
public ?string $cardToken;
19+
public ?bool $cardSavingApproved;
20+
public ?string $expiryMonth;
21+
public ?string $expiryYear;
2222

2323
public static function fromArray(array $data): self
2424
{
2525
$obj = new self();
26-
$obj->maskedCardNumber = $data['maskedCardNumber'];
27-
$obj->cardHolderName = $data['cardHolderName'] ?? '';
28-
$obj->type = $data['type'];
29-
$obj->issuerCountry = $data['issuerCountry'];
30-
$obj->cardToken = $data['cardToken'];
31-
$obj->cardSavingApproved = $data['cardSavingApproved'] ?? false;
32-
$obj->expiryMonth = $data['expiryMonth'] ?? '';
33-
$obj->expiryYear = $data['expiryYear'] ?? '';
26+
$obj->maskedCardNumber = $data['maskedCardNumber'] ?? null;
27+
$obj->cardHolderName = $data['cardHolderName'] ?? null;
28+
$obj->type = $data['type'] ?? null;
29+
$obj->issuerCountry = $data['issuerCountry'] ?? null;
30+
$obj->cardToken = $data['cardToken'] ?? null;
31+
$obj->cardSavingApproved = $data['cardSavingApproved'] ?? null;
32+
$obj->expiryMonth = $data['expiryMonth'] ?? null;
33+
$obj->expiryYear = $data['expiryYear'] ?? null;
3434
return $obj;
3535
}
3636

37-
public function getCardToken(): string
37+
public function getCardToken(): ?string
3838
{
3939
return $this->cardToken;
4040
}
4141

42-
public function getExpiryMonth(): string
42+
public function getExpiryMonth(): ?string
4343
{
4444
return $this->expiryMonth;
4545
}
4646

47-
public function getExpiryYear(): string
47+
public function getExpiryYear(): ?string
4848
{
4949
return $this->expiryYear;
5050
}
5151

52-
public function getCardSavingApproved(): string
52+
public function getCardSavingApproved(): ?bool
5353
{
5454
return $this->cardSavingApproved;
5555
}
5656

57-
public function getMaskedCardNumber(): string
57+
public function getMaskedCardNumber(): ?string
5858
{
5959
return $this->maskedCardNumber;
6060
}
6161

62-
public function getType(): string
62+
public function getType(): ?string
6363
{
6464
return $this->type;
6565
}

0 commit comments

Comments
 (0)