Skip to content
This repository was archived by the owner on Mar 24, 2023. It is now read-only.

Commit 69b64ab

Browse files
Main: Introduced new activity to show no root status
Signed-off-by: sunilpaulmathew <sunil.kde@gmail.com>
1 parent 38b93d1 commit 69b64ab

6 files changed

Lines changed: 131 additions & 10 deletions

File tree

app/src/main/AndroidManifest.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@
3232
</intent-filter>
3333
</activity>
3434

35-
<activity android:name="com.smartpack.kernelprofiler.utils.CreateConfigActivity" />
36-
<activity android:name="com.smartpack.kernelprofiler.utils.CreateProfileActivity" />
37-
<activity android:name="com.smartpack.kernelprofiler.utils.EditConfigActivity" />
35+
<activity android:name=".utils.CreateConfigActivity" />
36+
<activity android:name=".utils.CreateProfileActivity" />
37+
<activity android:name=".utils.EditConfigActivity" />
38+
<activity android:name=".utils.NoRootActivity" />
3839

3940
<receiver
4041
android:name=".utils.OnBootReceiver"

app/src/main/java/com/smartpack/kernelprofiler/MainActivity.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import com.smartpack.kernelprofiler.utils.CreateProfileActivity;
2929
import com.smartpack.kernelprofiler.utils.EditConfigActivity;
3030
import com.smartpack.kernelprofiler.utils.KP;
31+
import com.smartpack.kernelprofiler.utils.NoRootActivity;
3132
import com.smartpack.kernelprofiler.utils.PagerAdapter;
3233
import com.smartpack.kernelprofiler.utils.Prefs;
3334
import com.smartpack.kernelprofiler.utils.Utils;
@@ -115,12 +116,9 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
115116
});
116117

117118
if (!RootUtils.rootAccess()) {
118-
textView.setText(getString(R.string.no_root));
119-
helpIcon.setImageDrawable(Utils.getColoredIcon(R.drawable.ic_help, this));
120-
Utils.snackbar(mViewPager, getString(R.string.no_root_message));
121-
helpIcon.setOnClickListener(v -> {
122-
launchURL("https://www.google.com/search?site=&source=hp&q=android+rooting+magisk");
123-
});
119+
Intent noRoot = new Intent(this, NoRootActivity.class);
120+
startActivity(noRoot);
121+
finish();
124122
return;
125123
}
126124

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
package com.smartpack.kernelprofiler.utils;
2+
3+
import android.os.Bundle;
4+
5+
import androidx.annotation.Nullable;
6+
import androidx.appcompat.app.AppCompatActivity;
7+
import androidx.appcompat.widget.AppCompatImageButton;
8+
import androidx.appcompat.widget.AppCompatTextView;
9+
10+
import com.smartpack.kernelprofiler.R;
11+
12+
/**
13+
* Created by sunilpaulmathew <sunil.kde@gmail.com> on September 16, 2020
14+
*/
15+
16+
public class NoRootActivity extends AppCompatActivity {
17+
18+
@Override
19+
protected void onCreate(@Nullable Bundle savedInstanceState) {
20+
super.onCreate(savedInstanceState);
21+
setContentView(R.layout.activity_noroot);
22+
23+
AppCompatImageButton mBack = findViewById(R.id.back_button);
24+
AppCompatTextView mCancel = findViewById(R.id.cancel_button);
25+
mBack.setOnClickListener(v -> onBackPressed());
26+
mCancel.setOnClickListener(v -> super.onBackPressed());
27+
}
28+
29+
}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<vector android:height="24dp"
2+
android:viewportHeight="24.0" android:viewportWidth="24.0"
3+
android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android">
4+
<path android:fillColor="#FF000000" android:pathData="M11,17h2v-6h-2v6zM12,2C6.48,2 2,6.48 2,12s4.48,10 10,10 10,-4.48 10,-10S17.52,2 12,2zM12,20c-4.41,0 -8,-3.59 -8,-8s3.59,-8 8,-8 8,3.59 8,8 -3.59,8 -8,8zM11,9h2L13,7h-2v2z"/>
5+
</vector>
Lines changed: 88 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,88 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<androidx.cardview.widget.CardView
3+
android:layout_width="match_parent"
4+
android:layout_height="match_parent"
5+
android:layout_gravity="center"
6+
android:padding="16dp"
7+
xmlns:android="http://schemas.android.com/apk/res/android">
8+
9+
<LinearLayout
10+
android:layout_width="match_parent"
11+
android:layout_height="match_parent"
12+
android:orientation="vertical">
13+
14+
<FrameLayout
15+
android:layout_width="match_parent"
16+
android:layout_height="50dp"
17+
android:background="@color/black"
18+
android:gravity="end|center_vertical">
19+
20+
<androidx.appcompat.widget.AppCompatImageButton
21+
android:id="@+id/back_button"
22+
android:layout_width="50dp"
23+
android:layout_height="50dp"
24+
android:gravity="center_vertical"
25+
android:layout_gravity="start"
26+
android:src="@drawable/ic_back"
27+
android:background="@color/black"
28+
android:tint="?android:attr/colorAccent"/>
29+
30+
<androidx.appcompat.widget.AppCompatTextView
31+
android:layout_width="wrap_content"
32+
android:layout_height="50dp"
33+
android:layout_marginStart="50dp"
34+
android:layout_marginEnd="50dp"
35+
android:gravity="center_vertical"
36+
android:layout_gravity="center"
37+
android:text="@string/no_root"
38+
android:textStyle="bold"
39+
android:textSize="20sp"
40+
android:padding="10dp"
41+
android:textColor="?android:attr/colorAccent" />
42+
</FrameLayout>
43+
44+
<ScrollView
45+
android:layout_width="match_parent"
46+
android:layout_height="match_parent"
47+
android:scrollbars="vertical"
48+
android:layout_marginBottom="50dp" >
49+
50+
<LinearLayout
51+
android:layout_width="match_parent"
52+
android:layout_height="wrap_content"
53+
android:orientation="horizontal" >
54+
55+
<androidx.appcompat.widget.AppCompatImageButton
56+
android:layout_width="50dp"
57+
android:layout_height="50dp"
58+
android:gravity="center_vertical"
59+
android:layout_gravity="start|center"
60+
android:src="@drawable/ic_info"
61+
android:background="@null"
62+
android:tint="?android:attr/colorAccent"/>
63+
64+
<androidx.appcompat.widget.AppCompatTextView
65+
android:layout_width="match_parent"
66+
android:layout_height="wrap_content"
67+
android:layout_gravity="top"
68+
android:padding="10dp"
69+
android:gravity="start"
70+
android:text="@string/no_root_message"
71+
android:textColor="?android:attr/textColorPrimary"
72+
android:textSize="17sp" />
73+
</LinearLayout>
74+
</ScrollView>
75+
</LinearLayout>
76+
77+
<androidx.appcompat.widget.AppCompatTextView
78+
android:id="@+id/cancel_button"
79+
android:layout_width="match_parent"
80+
android:layout_height="50dp"
81+
android:gravity="center"
82+
android:layout_gravity="bottom|center"
83+
android:textStyle="bold"
84+
android:background="@color/black"
85+
android:text="@string/cancel"
86+
android:textColor="?android:attr/colorAccent"
87+
android:textSize="18sp" />
88+
</androidx.cardview.widget.CardView>

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
<string name="name_empty">Profile name shouldn\'t be empty! Aborting.</string>
5050
<string name="no_internet">Please check your internet connection!</string>
5151
<string name="no_root">No Root</string>
52-
<string name="no_root_message">This app won\'t work without Root Access! Aborting.</string>
52+
<string name="no_root_message"><b>Why this issue happened?</b>\n\nYour device is either not rooted, or the root permission is declined for Kernel Profiler by you!\n\n\n<b>Why root permission needed?</b>\n\nIn order to execute, or apply a kernel profile on boot, Kernel Profiler needs superuser permissions, and is impossible on a device without root access!\n\n\n<b>How can I root my device?</b>\n\nA simple google search will help to find many guides to achieve root on your device. Please have a look at it!\n\n\n<b>Is rooting a device safe?</b>\n\nRooting poses some security risk, but it\'s generally safe to do!</string>
5353
<string name="ok">OK</string>
5454
<string name="on_boot">Applying Settings…</string>
5555
<string name="on_boot_conformation">%s is already assigned as the default profile!</string>

0 commit comments

Comments
 (0)