Skip to content
This repository was archived by the owner on Mar 24, 2023. It is now read-only.

Commit fc32308

Browse files
Improved Ad Layout
Signed-off-by: sunilpaulmathew <sunil.kde@gmail.com>
1 parent 69b64ab commit fc32308

2 files changed

Lines changed: 34 additions & 16 deletions

File tree

app/src/main/java/com/smartpack/kernelprofiler/MainActivity.java

Lines changed: 26 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import android.view.Menu;
1111
import android.view.SubMenu;
1212
import android.view.View;
13+
import android.view.ViewGroup;
1314

1415
import androidx.annotation.Nullable;
1516
import androidx.appcompat.app.AlertDialog;
@@ -21,8 +22,10 @@
2122
import androidx.cardview.widget.CardView;
2223
import androidx.viewpager.widget.ViewPager;
2324

25+
import com.google.android.gms.ads.AdListener;
2426
import com.google.android.gms.ads.AdRequest;
2527
import com.google.android.gms.ads.AdView;
28+
import com.google.android.gms.ads.LoadAdError;
2629
import com.smartpack.kernelprofiler.fragments.KPFragment;
2730
import com.smartpack.kernelprofiler.utils.CreateConfigActivity;
2831
import com.smartpack.kernelprofiler.utils.CreateProfileActivity;
@@ -44,6 +47,7 @@ public class MainActivity extends AppCompatActivity {
4447
private boolean mExit;
4548
private Handler mHandler = new Handler();
4649
private ViewPager mViewPager;
50+
private ViewGroup.MarginLayoutParams mLayoutParams;
4751

4852
private AppCompatImageButton mBack;
4953
private AppCompatImageView mAppIcon;
@@ -94,15 +98,10 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
9498
Utils.launchUrl("https://github.com/sunilpaulmathew", this);
9599
});
96100

97-
if (Utils.isNotDonated(this)) {
98-
AdView mAdView = findViewById(R.id.adView);
99-
AdRequest adRequest = new AdRequest.Builder()
100-
.build();
101-
mAdView.loadAd(adRequest);
102-
}
103-
104101
mSettings = findViewById(R.id.settings_menu);
105102
mViewPager = findViewById(R.id.viewPagerID);
103+
mLayoutParams = (ViewGroup.MarginLayoutParams) mViewPager.getLayoutParams();
104+
AdView mAdView = findViewById(R.id.adView);
106105
AppCompatTextView textView = findViewById(R.id.unsupported_Text);
107106
AppCompatImageView helpIcon = findViewById(R.id.help_Image);
108107
AppCompatTextView copyRightText = findViewById(R.id.copyright_Text);
@@ -139,6 +138,26 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
139138
return;
140139
}
141140

141+
if (Utils.isNotDonated(this)) {
142+
mAdView.setAdListener(new AdListener() {
143+
@Override
144+
public void onAdLoaded() {
145+
copyRightText.setVisibility(View.GONE);
146+
}
147+
@Override
148+
public void onAdFailedToLoad(LoadAdError adError) {
149+
mAdView.setVisibility(View.GONE);
150+
mLayoutParams.bottomMargin = 0;
151+
}
152+
});
153+
AdRequest adRequest = new AdRequest.Builder()
154+
.build();
155+
mAdView.loadAd(adRequest);
156+
} else {
157+
mAdView.setVisibility(View.GONE);
158+
mLayoutParams.bottomMargin = 0;
159+
}
160+
142161
PagerAdapter adapter = new PagerAdapter(getSupportFragmentManager());
143162
adapter.AddFragment(new KPFragment(), getString(R.string.app_name));
144163

app/src/main/res/layout/activity_main.xml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,13 @@
6767
android:layout_width="match_parent"
6868
android:layout_height="match_parent" >
6969

70+
<androidx.viewpager.widget.ViewPager
71+
android:layout_width="match_parent"
72+
android:layout_height="match_parent"
73+
android:layout_marginTop="115dp"
74+
android:layout_marginBottom="90dp"
75+
android:id="@+id/viewPagerID" />
76+
7077
<androidx.appcompat.widget.AppCompatTextView
7178
android:id="@+id/unsupported_Text"
7279
android:layout_width="match_parent"
@@ -103,18 +110,10 @@
103110
android:layout_width="wrap_content"
104111
android:layout_height="wrap_content"
105112
android:layout_gravity="bottom|center"
106-
ads:adSize="BANNER"
107-
android:background="@android:color/transparent"
113+
ads:adSize="SMART_BANNER"
108114
ads:adUnitId="ca-app-pub-7791710838910455/5158225354" >
109115
</com.google.android.gms.ads.AdView>
110116
</FrameLayout>
111117

112118
<include layout="@layout/rv_foreground_view" />
113-
114-
<androidx.viewpager.widget.ViewPager
115-
android:layout_width="match_parent"
116-
android:layout_height="match_parent"
117-
android:layout_marginTop="115dp"
118-
android:layout_marginBottom="50dp"
119-
android:id="@+id/viewPagerID" />
120119
</RelativeLayout>

0 commit comments

Comments
 (0)