[feat] add update_in_insert and lazy_update_in_insert options - #142
Open
spflaumer wants to merge 13 commits into
Open
[feat] add update_in_insert and lazy_update_in_insert options#142spflaumer wants to merge 13 commits into
spflaumer wants to merge 13 commits into
Conversation
aka. fix comparison with vim.b.navic_update_in_insert for "CursorHoldI" event
Owner
|
Does this achieve same as #168 ? |
Author
|
Yes, but this also adds options to control that behavior for users that may not want updates in Insert mode. Reading the code a year later, it isn't the best and the commit messages suck, so I might want to redo this if you consider the config options a useful addition |
Owner
|
Sure 👍🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
update_in_insertandlazy_update_in_insertoptions, with their respectivevim.b.update_in_insertandvim.b.lazy_update_in_insertcounterparts, allow the user of the plugin to enable updating the context while in Insert mode.Currently, the information returned by
get_data, and it'sget_locationwrapper, is the same as when first entering Insert mode.Now the context will update in insert mode, providing a fresh context with the "CursorHoldI" and "CursorMovedI" events.