Skip to content

Enable initialize_gigl_runtime in all components #663

Merged
kmontemayor2-sc merged 6 commits into
mainfrom
kmonte/gigl-runtime-in-components
Jun 11, 2026
Merged

Enable initialize_gigl_runtime in all components #663
kmontemayor2-sc merged 6 commits into
mainfrom
kmonte/gigl-runtime-in-components

Conversation

@kmontemayor2-sc

@kmontemayor2-sc kmontemayor2-sc commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Scope of work done

As a follow up to #661 we should expose these env vars everywhere (this let's user code be consistent across the code base).

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@kmontemayor2-sc

kmontemayor2-sc commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

/all_test

@github-actions

github-actions Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 18:18:11UTC : 🔄 Python Unit Test started.

@ 19:22:41UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 18:18:11UTC : 🔄 Lint Test started.

@ 18:26:23UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 18:18:11UTC : 🔄 Scala Unit Test started.

@ 18:28:23UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 18:18:11UTC : 🔄 C++ Unit Test started.

@ 18:19:58UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 18:18:11UTC : 🔄 Integration Test started.

@ 19:45:32UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 18:18:14UTC : 🔄 E2E Test started.

mkolodner-sc
mkolodner-sc reviewed Jun 9, 2026
View reviewed changes

@mkolodner-sc mkolodner-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle! A few comments/questions

Comment thread gigl/orchestration/local/runner.py Outdated
Comment thread gigl/orchestration/kubeflow/components/data_preprocessor/component.yaml
Comment thread gigl/orchestration/kubeflow/components/post_processor/component.yaml
Comment thread gigl/src/training/v1/trainer.py
kmontemayor and others added 2 commits June 9, 2026 20:26
Merge branch 'main' into kmonte/gigl-runtime-in-components
a5b78f4
@claude
Move component-skip logic into initialize_gigl_runtime
d5781f3 
For SubgraphSampler and SplitGenerator, initialize_gigl_runtime now
initializes metrics only and skips runtime env-var setup. This centralizes
the per-component skip decision in the runtime initializer instead of the
local orchestration runner, so Runner._initialize_component_runtime becomes
a thin marshaller.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kmontemayor2-sc

kmontemayor2-sc commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

/all_test

@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 01:45:57UTC : 🔄 C++ Unit Test started.

@ 01:47:55UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 01:45:57UTC : 🔄 Scala Unit Test started.

@ 01:54:40UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 01:45:59UTC : 🔄 Python Unit Test started.

@ 02:53:08UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 01:46:01UTC : 🔄 Lint Test started.

@ 01:54:19UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 01:46:01UTC : 🔄 Integration Test started.

@ 02:58:30UTC : ✅ Workflow completed successfully.

@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

GiGL Automation

@ 01:46:01UTC : 🔄 E2E Test started.

@ 03:13:10UTC : ✅ Workflow completed successfully.

kmontemayor and others added 2 commits June 10, 2026 17:14
@claude
Thread cpu/cuda docker URIs through ConfigPopulator and ConfigValidator
1715cfb 
Brings ConfigPopulator and ConfigValidator to parity with the other
components by threading cpu_docker_uri/cuda_docker_uri (and thus the
GIGL_CPU_DOCKER_URI/GIGL_CUDA_DOCKER_URI env vars) through every
entrypoint: the CLI mains, KFP component specs and wiring, and the local
Runner (which now routes both through _initialize_component_runtime).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
Document SGS/SplitGen runtime skip and TODO dataflow docker URI
c6679bc 
Note in the SubgraphSampler and SplitGenerator mains that these legacy
Scala/Spark components only initialize metrics (not the full GiGL runtime
env vars), mirroring the skip branch in initialize_gigl_runtime. Also add
a TODO to expose the dataflow docker URI as a GIGL env var for parity with
the CPU/CUDA docker URIs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mkolodner-sc
mkolodner-sc approved these changes Jun 10, 2026
View reviewed changes

@mkolodner-sc mkolodner-sc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle!

@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review June 11, 2026 00:31
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Jun 11, 2026
Merged via the queue into main with commit e5d6383 Jun 11, 2026
7 checks passed
@kmontemayor2-sc kmontemayor2-sc deleted the kmonte/gigl-runtime-in-components branch June 11, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yliu2-sc yliu2-sc yliu2-sc approved these changes

@mkolodner-sc mkolodner-sc mkolodner-sc approved these changes

@svij-sc svij-sc Awaiting requested review from svij-sc svij-sc is a code owner

@nshah-sc nshah-sc Awaiting requested review from nshah-sc nshah-sc is a code owner

@xgao4-sc xgao4-sc Awaiting requested review from xgao4-sc xgao4-sc is a code owner

@zfan3-sc zfan3-sc Awaiting requested review from zfan3-sc zfan3-sc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kmontemayor2-sc @yliu2-sc @mkolodner-sc @kmonte