Skip to content

Commit 9357df6

Browse files
committed
Revert build changes
1 parent d181ad4 commit 9357df6

3 files changed

Lines changed: 25 additions & 14 deletions

File tree

bin/BUILD.bazel

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ load(
66
"pngquant_linux",
77
"pngquant_macos",
88
"valdi_compiler_companion_files",
9-
"valdi_compiler_linux",
10-
"valdi_compiler_macos",
119
)
1210

1311
filegroup(
@@ -20,8 +18,8 @@ native_binary(
2018
name = "valdi_compiler",
2119
src = select(
2220
{
23-
"@bazel_tools//src/conditions:darwin": valdi_compiler_macos(),
24-
"@bazel_tools//src/conditions:linux_x86_64": valdi_compiler_linux(),
21+
"@bazel_tools//src/conditions:darwin": "@valdi_compiler_macos//:valdi_compiler",
22+
"@bazel_tools//src/conditions:linux_x86_64": "@valdi_compiler_linux//:valdi_compiler",
2523
},
2624
),
2725
out = "valdi_compiler",

bzl/prebuilt_tools.bzl

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,6 @@ def pngquant_macos():
1212
return "@valdi_pngquant_macos//:pngquant"
1313
return "pngquant/macos/pngquant"
1414

15-
def valdi_compiler_macos():
16-
if INTERNAL_BUILD:
17-
pass
18-
return "compiler/macos/valdi_compiler"
19-
20-
def valdi_compiler_linux():
21-
if INTERNAL_BUILD:
22-
pass
23-
return "compiler/linux/valdi_compiler"
24-
2515
def valdi_compiler_companion_files():
2616
if INTERNAL_BUILD:
2717
return ["@valdi_compiler_companion//:all_files"]

bzl/valdi/valdi_exported_library.bzl

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
load("@build_bazel_rules_apple//apple:apple.bzl", "apple_xcframework")
22
load("//bzl:expand_template.bzl", "expand_template")
3+
load("//bzl/android:collect_android_assets.bzl", "collect_android_assets")
34
load("//bzl/valdi:rewrite_hdrs.bzl", "rewrite_hdrs")
45
load("//bzl/valdi:suffixed_deps.bzl", "get_suffixed_deps")
56
load("//bzl/valdi:valdi_collapse_web_paths.bzl", "collapse_native_paths", "collapse_web_paths")
@@ -76,6 +77,28 @@ def valdi_exported_library(
7677

7778
java_deps = java_deps + get_suffixed_deps(deps, "_kt")
7879

80+
collect_android_assets(
81+
name = "{}_android_assets".format(name),
82+
valdi_deps = deps,
83+
deps = java_deps,
84+
output_target = source_set_select(
85+
debug = "debug",
86+
release = "release",
87+
),
88+
)
89+
90+
valdi_android_aar(
91+
name = "{}_android".format(name),
92+
java_deps = java_deps,
93+
native_deps = [
94+
"@valdi//valdi",
95+
] + get_suffixed_deps(deps, "_native"),
96+
additional_assets = [":{}_android_assets".format(name)],
97+
excluded_class_path_patterns = android_excluded_class_path_patterns,
98+
so_name = "lib{}.so".format(name),
99+
tags = ["valdi_android_exported_library"],
100+
)
101+
79102
package_name = web_package_name
80103
if npm_scope:
81104
package_name = npm_scope + "/" + package_name

0 commit comments

Comments
 (0)