Cherry-pick Yoga UDL fix for beta-0.1.1#111
Conversation
Newer Clang versions treat `operator"" _pt` (with space) as -Werror,-Wdeprecated-literal-operator. Remove the space so it compiles cleanly: `operator""_pt`. Cherry-picked from main (1c6d740).
Sensitive Files Detected🧘 Yoga layout engine — HIGH blast radius — affects all layout. Verify layout tests exist and pass. This is an automated notice. A maintainer will review after import. |
📊 PR Size: size/STotal changes: 12 lines (1 files) Top files changed:
Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+) |
🎉 Bazel & CI Test Results
All Bazel configuration and CI tests passed! ✨ The build system and core tooling are working correctly. 🚀 Bazel remote cache is now enabled - future builds will be faster! Workflow: Valdi CI |
Newer Clang versions (shipping on recent macOS GitHub Actions runners) error on memcpy with non-trivially copyable types. Add -Wno-nontrivial-memcall to COMPILER_FLAGS_COMPAT to match the fix already on main (1b5419b). Cherry-picked for beta-0.1.1.
|
| Test Suite | Result |
|---|---|
| Linux: Build & Export | ✅ success |
| Valdi Smoke Tests | ❌ failure |
| Snapshot Tests | ✅ success |
| Linux: C++ Tests | ✅ success |
| Comment Test Results / Post Results Comment | ❌ null |
Some tests failed. Please check the workflow logs for details.
🚀 Bazel disk cache is enabled - builds with warm cache will be faster!
Workflow: Valdi CI
Newer Clang versions error on memcpy with non-trivially copyable types (-Werror,-Wnontrivial-memcall). The valdi_hermes target includes Hermes headers that trigger this in HermesBytecodeCache.cpp. Suppress the warning in the valdi_hermes copts to match the fix already applied to third-party/hermes/hermes.BUILD.
|
| Test Suite | Result |
|---|---|
| Snapshot Tests | ❌ failure |
| Linux: C++ Tests | ✅ success |
| Valdi Smoke Tests | ✅ success |
| Linux: Build & Export | ✅ success |
| Comment Test Results / Post Results Comment | ❌ null |
Some tests failed. Please check the workflow logs for details.
🚀 Bazel disk cache is enabled - builds with warm cache will be faster!
Workflow: Valdi CI
|
| Test Suite | Result |
|---|---|
| Snapshot Tests | ✅ success |
| Valdi Smoke Tests | ✅ success |
| Linux: Build & Export | ✅ success |
| Linux: C++ Tests | ✅ success |
| Comment Test Results / Post Results Comment | ❌ null |
Some tests failed. Please check the workflow logs for details.
🚀 Bazel disk cache is enabled - builds with warm cache will be faster!
Workflow: Valdi CI
1 participant
Summary
Cherry-pick the Yoga
YGValue.hUDL syntax fix frommain(1c6d7408) to the release branch.Newer Clang versions (shipped with recent macOS GitHub Actions runners) treat
operator"" _pt(with space before the suffix) as-Werror,-Wdeprecated-literal-operator. This removes the space so it compiles cleanly.This was breaking:
Test Plan
CI on this PR should pass. After merge,
beta-0.1.1will be retagged at the new branch head.