diff --git a/third-party/hermes/hermes.BUILD b/third-party/hermes/hermes.BUILD index e221201b..45ef60f2 100644 --- a/third-party/hermes/hermes.BUILD +++ b/third-party/hermes/hermes.BUILD @@ -20,6 +20,7 @@ COMPILER_FLAGS_COMPAT = [ "-Wno-deprecated-pragma", "-Wno-unused-variable", "-Wno-implicit-fallthrough", + "-Wno-nontrivial-memcall", "-Wno-unknown-warning-option", ] diff --git a/third-party/yoga/src/yoga/YGValue.h b/third-party/yoga/src/yoga/YGValue.h index aaa10c3f..0833f624 100755 --- a/third-party/yoga/src/yoga/YGValue.h +++ b/third-party/yoga/src/yoga/YGValue.h @@ -63,18 +63,18 @@ namespace facebook { namespace yoga { namespace literals { -inline YGValue operator"" _pt(long double value) { +inline YGValue operator""_pt(long double value) { return YGValue{static_cast(value), YGUnitPoint}; } -inline YGValue operator"" _pt(unsigned long long value) { - return operator"" _pt(static_cast(value)); +inline YGValue operator""_pt(unsigned long long value) { + return operator""_pt(static_cast(value)); } -inline YGValue operator"" _percent(long double value) { +inline YGValue operator""_percent(long double value) { return YGValue{static_cast(value), YGUnitPercent}; } -inline YGValue operator"" _percent(unsigned long long value) { - return operator"" _percent(static_cast(value)); +inline YGValue operator""_percent(unsigned long long value) { + return operator""_percent(static_cast(value)); } } // namespace literals diff --git a/valdi/BUILD.bazel b/valdi/BUILD.bazel index d3bf9841..3be09bdf 100644 --- a/valdi/BUILD.bazel +++ b/valdi/BUILD.bazel @@ -228,6 +228,7 @@ cc_library( copts = COMPILER_FLAGS_COMPAT + COMMON_COMPILE_FLAGS + [ "-Wno-deprecated-this-capture", "-Wno-vla-cxx-extension", + "-Wno-nontrivial-memcall", ], defines = ["VALDI_HAS_HERMES"], local_defines = select({ @@ -1105,3 +1106,4 @@ filegroup( ]), visibility = ["//visibility:public"], ) +