From a911cf4befb1c4371d5913b43e379e64dcd1569e Mon Sep 17 00:00:00 2001 From: Carson Holgate Date: Mon, 29 Jun 2026 10:33:32 -0700 Subject: [PATCH 1/3] Fix Yoga UDL syntax: remove space before literal operator suffix Newer Clang versions treat `operator"" _pt` (with space) as -Werror,-Wdeprecated-literal-operator. Remove the space so it compiles cleanly: `operator""_pt`. Cherry-picked from main (1c6d7408). --- third-party/yoga/src/yoga/YGValue.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/third-party/yoga/src/yoga/YGValue.h b/third-party/yoga/src/yoga/YGValue.h index aaa10c3f..0833f624 100755 --- a/third-party/yoga/src/yoga/YGValue.h +++ b/third-party/yoga/src/yoga/YGValue.h @@ -63,18 +63,18 @@ namespace facebook { namespace yoga { namespace literals { -inline YGValue operator"" _pt(long double value) { +inline YGValue operator""_pt(long double value) { return YGValue{static_cast(value), YGUnitPoint}; } -inline YGValue operator"" _pt(unsigned long long value) { - return operator"" _pt(static_cast(value)); +inline YGValue operator""_pt(unsigned long long value) { + return operator""_pt(static_cast(value)); } -inline YGValue operator"" _percent(long double value) { +inline YGValue operator""_percent(long double value) { return YGValue{static_cast(value), YGUnitPercent}; } -inline YGValue operator"" _percent(unsigned long long value) { - return operator"" _percent(static_cast(value)); +inline YGValue operator""_percent(unsigned long long value) { + return operator""_percent(static_cast(value)); } } // namespace literals From edf56e769aa2ba1d29a8ec32b38145c3b54cde01 Mon Sep 17 00:00:00 2001 From: Carson Holgate Date: Wed, 1 Jul 2026 09:46:22 -0700 Subject: [PATCH 2/3] Fix Hermes Clang -Wno-nontrivial-memcall for newer macOS runners Newer Clang versions (shipping on recent macOS GitHub Actions runners) error on memcpy with non-trivially copyable types. Add -Wno-nontrivial-memcall to COMPILER_FLAGS_COMPAT to match the fix already on main (1b5419ba). Cherry-picked for beta-0.1.1. --- third-party/hermes/hermes.BUILD | 1 + 1 file changed, 1 insertion(+) diff --git a/third-party/hermes/hermes.BUILD b/third-party/hermes/hermes.BUILD index e221201b..45ef60f2 100644 --- a/third-party/hermes/hermes.BUILD +++ b/third-party/hermes/hermes.BUILD @@ -20,6 +20,7 @@ COMPILER_FLAGS_COMPAT = [ "-Wno-deprecated-pragma", "-Wno-unused-variable", "-Wno-implicit-fallthrough", + "-Wno-nontrivial-memcall", "-Wno-unknown-warning-option", ] From f1086d0e36f2d51a1bc25097f1c5ef5347e278d6 Mon Sep 17 00:00:00 2001 From: Carson Holgate Date: Wed, 1 Jul 2026 11:54:24 -0700 Subject: [PATCH 3/3] Fix valdi_hermes -Wno-nontrivial-memcall for newer Clang Newer Clang versions error on memcpy with non-trivially copyable types (-Werror,-Wnontrivial-memcall). The valdi_hermes target includes Hermes headers that trigger this in HermesBytecodeCache.cpp. Suppress the warning in the valdi_hermes copts to match the fix already applied to third-party/hermes/hermes.BUILD. --- valdi/BUILD.bazel | 2 ++ 1 file changed, 2 insertions(+) diff --git a/valdi/BUILD.bazel b/valdi/BUILD.bazel index d3bf9841..3be09bdf 100644 --- a/valdi/BUILD.bazel +++ b/valdi/BUILD.bazel @@ -228,6 +228,7 @@ cc_library( copts = COMPILER_FLAGS_COMPAT + COMMON_COMPILE_FLAGS + [ "-Wno-deprecated-this-capture", "-Wno-vla-cxx-extension", + "-Wno-nontrivial-memcall", ], defines = ["VALDI_HAS_HERMES"], local_defines = select({ @@ -1105,3 +1106,4 @@ filegroup( ]), visibility = ["//visibility:public"], ) +