Skip to content

Fix the incorrect Boxer Address in the Boxer client#65

Merged
s-vitaliy merged 3 commits into
mainfrom
fix-incorrect-boxer-url
Apr 30, 2026
Merged

Fix the incorrect Boxer Address in the Boxer client#65
s-vitaliy merged 3 commits into
mainfrom
fix-incorrect-boxer-url

Conversation

@s-vitaliy

@s-vitaliy s-vitaliy commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Resolves #63

Scope

Implemented:

  • Removed outdated code
  • Fixed the Boxer URI

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy
s-vitaliy force-pushed the fix-incorrect-boxer-url branch from b1652b6 to a6d3ff6 Compare April 30, 2026 13:14
var authorizationProvider = boxerTokenProviderOptions.Value.IdentityProvider
?? throw new ArgumentNullException(nameof(BoxerTokenProviderOptions.IdentityProvider));
this.authProvider = new Uri($"token/{authorizationProvider}", UriKind.Relative);
this.authProvider = new Uri($"api/v1/token/{authorizationProvider}", UriKind.Relative);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual fix is here

@s-vitaliy
s-vitaliy marked this pull request as ready for review April 30, 2026 13:18
@s-vitaliy
s-vitaliy requested a review from a team as a code owner April 30, 2026 13:18
@s-vitaliy
s-vitaliy merged commit 87ff043 into main Apr 30, 2026
1 check passed
@s-vitaliy
s-vitaliy deleted the fix-incorrect-boxer-url branch April 30, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cleanup] Delete deprecated services

2 participants