Skip to content

Ensure successful status code check for token response#67

Merged
s-vitaliy merged 1 commit into
mainfrom
ensure-status-code-check
May 5, 2026
Merged

Ensure successful status code check for token response#67
s-vitaliy merged 1 commit into
mainfrom
ensure-status-code-check

Conversation

@s-vitaliy

Copy link
Copy Markdown
Contributor

This pull request makes a targeted improvement to the GetTokenAsync method in BoxerTokenProvider.cs by ensuring that HTTP requests for tokens only proceed if the response is successful.

  • Reliability improvement:
    • Added a call to response.EnsureSuccessStatusCode() to throw an exception if the HTTP response is not successful, preventing the use of invalid or error responses when retrieving the boxer token.

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy
s-vitaliy requested a review from a team as a code owner May 4, 2026 14:16
@s-vitaliy
s-vitaliy requested a review from george-zubrienko May 4, 2026 14:16
@s-vitaliy
s-vitaliy merged commit 8ac1b6a into main May 5, 2026
1 check passed
@s-vitaliy
s-vitaliy deleted the ensure-status-code-check branch May 5, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants