Skip to content

Commit fa002af

Browse files
SnoopLawgclaude
andcommitted
M1: document tested-and-reverted DoT tick-order finding (Venom poison)
Investigated the Venom poison under-attribution (#11) against Spirit fixture 20260623_162050. Cadence is perfect (sim casts == real exactly), so the gap is poison tick production: real 74 ticks vs sim 50. Pinned the mechanic: 72 poison placements (Maneater A1 x40 + Venom A3 x2x16) -> 74 real ticks ~= 1 tick/placement. Real poisons are detonation-consumed by Venom A1 (tick once, then removed), NOT lasting 2 full turns. Tested reordering the DoT damage loops before debuff_bar.tick() (deal on the expiry turn): total -5.6% -> -1.2% but Venom flipped to +16.2% OVER (50 -> 94 ticks). That's a compensating-wrong swap (double-ticks long poisons), so REVERTED. Left an explanatory comment at the tick site. The clean fix is modeling poison detonation-consumption, validated against this fixture's 74-tick / 37.87M target — fixed together with the Geo deflect (downstream of burns), not in isolation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 816f830 commit fa002af

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

tools/cb_sim.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1321,6 +1321,17 @@ def _cb_turn(self, tick: int):
13211321
})
13221322

13231323
# Tick debuffs
1324+
# NOTE (2026-06-23): tested reordering the DoT damage loops to run
1325+
# BEFORE this tick() (so a DoT's expiry turn still deals a tick).
1326+
# Against Spirit fixture 20260623_162050 that lifted the total from
1327+
# -5.6% to -1.2% but pushed Venom poison from -9.4% to +16.2% OVER
1328+
# (50 -> 94 ticks vs real 74). Real has ~72 poison placements
1329+
# (Venom A3 x2 x16 + Maneater A1 x40) for ~74 ticks ≈ 1 tick/placement,
1330+
# i.e. poisons are consumed by Venom A1 detonation rather than ticking
1331+
# their full 2-turn duration. The reorder alone is a compensating-wrong
1332+
# swap; the real fix needs poison detonation-consumption modeled
1333+
# together. Reverted to tick-then-deal; see
1334+
# project_spirit_fixture_attribution_20260623.
13241335
self.debuff_bar.tick()
13251336

13261337
# Poison ticks — each active poison deals damage

0 commit comments

Comments
 (0)