Skip to content

Commit 334c3d0

Browse files
authored
Merge branch 'MCSManager:master' into master
2 parents 0d84d3b + 6add473 commit 334c3d0

7 files changed

Lines changed: 48 additions & 38 deletions

File tree

README.md

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,22 @@ Before contributing code to this project, please make sure to review the followi
257257
- Please maintain the existing code structure and formatting, **do not apply unnecessary or excessive formatting changes.**
258258
- All submitted code **must follow internationalization (i18n) standards**.
259259

260+
### Bug Reports
261+
262+
We welcome all bug reports and feedback. Your contributions help us improve the project.
263+
264+
If you encounter any issues, please report them via the [GitHub Issues](https://github.com/MCSManager/MCSManager/issues) page, and we’ll address them as soon as possible.
265+
266+
For serious **security vulnerabilities** that should not be disclosed publicly, please contact us directly at: **support@mcsmanager.com**
267+
268+
Once resolved, we will credit the discoverer in the relevant code or release notes.
269+
270+
### Acknowledgements
271+
272+
Thanks to the following developers for making important contributions to the security testing of MCSManager!
273+
274+
> @Execute, [@xiaosuyyds](https://github.com/xiaosuyyds)
275+
260276
<br />
261277

262278
## Development
@@ -308,17 +324,6 @@ MCSManager supports all major modern browsers, including:
308324

309325
<br />
310326

311-
## Bug Reports
312-
313-
We welcome all bug reports and feedback. Your contributions help us improve the project.
314-
315-
If you encounter any issues, please report them via the [GitHub Issues](https://github.com/MCSManager/MCSManager/issues) page, and we’ll address them as soon as possible.
316-
317-
For serious **security vulnerabilities** that should not be disclosed publicly, please contact us directly at: **support@mcsmanager.com**
318-
319-
Once resolved, we will credit the discoverer in the relevant code or release notes.
320-
321-
<br />
322327

323328
## Contributors
324329

README_ZH.md

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,18 @@ docker compose pull && docker compose up -d
247247

248248
- 所有代码必须符合国际化标准。
249249

250+
### BUG 报告
251+
252+
欢迎发现的任何问题进行反馈,必当及时修复。
253+
254+
若发现严重安全漏洞又不便公开发布,请发送邮件至: support@mcsmanager.com,安全问题修复后将在代码中附加漏洞发现者姓名。
255+
256+
### 鸣谢
257+
258+
感谢以下开发者为 MCSManager 安全性提供重要的代码贡献!
259+
260+
> @Execute, [@xiaosuyyds](https://github.com/xiaosuyyds)
261+
250262
<br />
251263

252264
## 开发此项目
@@ -294,14 +306,6 @@ docker compose pull && docker compose up -d
294306

295307
<br />
296308

297-
## BUG 报告
298-
299-
欢迎发现的任何问题进行反馈,必当及时修复。
300-
301-
若发现严重安全漏洞又不便公开发布,请发送邮件至: support@mcsmanager.com,安全问题修复后将在代码中附加漏洞发现者姓名。
302-
303-
<br />
304-
305309
## 贡献者
306310

307311
<a href="https://openomy.com/MCSManager/MCSManager" target="_blank" style="display: block; width: 100%;" align="center">

daemon/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "mcsmanager-daemon",
3-
"version": "4.16.0",
3+
"version": "4.16.1",
44
"description": "Provides remote control capability for MCSManager to manage processes, scheduled tasks, I/O streams, and more",
55
"scripts": {
66
"dev": "nodemon --watch src --ext ts,js --exec \"npm run build && node --enable-source-maps production/app.js\"",

frontend/src/widgets/InstanceList.vue

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -370,20 +370,20 @@ const handleSelectInstance = (item: InstanceMoreDetail) => {
370370
};
371371
372372
const selectAllInstances = () => {
373-
let allInstancesCount = 0;
374-
for (const node of tableTreeData.value) {
375-
if (!node.children) continue;
376-
allInstancesCount += node.children.length;
377-
}
378-
379373
selectedInstance.value = [];
380-
if (allInstancesCount === selectedInstance.value?.length) return;
381374
382-
for (const node of tableTreeData.value) {
383-
if (!node.children) continue;
384-
for (const child of node.children) {
385-
if (findInstance(child.inst)) continue;
386-
selectedInstance.value.push(child.inst);
375+
if (isGlobalDaemonMode.value) {
376+
for (const node of tableTreeData.value) {
377+
if (!node.children) continue;
378+
for (const child of node.children) {
379+
if (findInstance(child.inst)) continue;
380+
selectedInstance.value.push(child.inst);
381+
}
382+
}
383+
} else {
384+
for (const item of instancesMoreInfo.value) {
385+
if (findInstance(item)) continue;
386+
selectedInstance.value.push(item);
387387
}
388388
}
389389
};

panel/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "mcsmanager-panel",
3-
"version": "10.16.0",
4-
"daemonVersion": "4.16.0",
3+
"version": "10.16.1",
4+
"daemonVersion": "4.16.1",
55
"description": "Provide MCSManager with the ability to connect and control all Daemons, and provide API services for the front end.",
66
"scripts": {
77
"dev": "nodemon --watch src --ext ts,js --exec \"npm run build && node --enable-source-maps production/app.js\"",
@@ -72,4 +72,4 @@
7272
"webpack-cli": "^4.10.0",
7373
"webpack-node-externals": "^3.0.0"
7474
}
75-
}
75+
}

panel/src/app/middleware/validator.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ export default function (parameter: IParam) {
7474
try {
7575
parameter["params"] && check(ctx.params, parameter["params"]);
7676
parameter["query"] && check(ctx.query, parameter["query"]);
77-
parameter["body"] && check(ctx.request.body, parameter["body"]);
77+
if (parameter["body"] && Object.keys(parameter["body"]).length > 0)
78+
check(ctx.request.body, parameter["body"]);
7879
return await next();
7980
} catch (err: any) {
8081
ctx.status = 400;

panel/src/app/routers/instance_operate_router.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import permission from "../middleware/permission";
77
import validator from "../middleware/validator";
88
import { checkInstanceAdvancedParams, getAppMarketList } from "../service/instance_service";
99
import { operationLogger } from "../service/operation_logger";
10-
import { getUserUuid } from "../service/passport_service";
10+
import { getUserPermission, getUserUuid } from "../service/passport_service";
1111
import { timeUuid } from "../service/password";
1212
import { isHaveInstanceByUuid, isTopPermissionByUuid } from "../service/permission_service";
1313
import RemoteRequest, { RemoteRequestTimeoutError } from "../service/remote_command";
@@ -506,7 +506,7 @@ router.post(
506506
instanceUuid,
507507
taskName,
508508
parameter,
509-
role: ctx.session?.["role"] as ROLE // Permission check is performed in the daemon
509+
role: getUserPermission(ctx) // Permission check is performed in the daemon
510510
});
511511
ctx.body = result;
512512
} catch (err) {

0 commit comments

Comments
 (0)