koko-aio shaders do not work properly outside of librashader-cli

[Cacodemon345]

This is on ares with the latest release of librashader:

Same on 86Box (image crossposted from 86Box/86Box#7370):

This is how it is supposed to look on RetroArch:

[chyyran]

Which backend is the 86box being reported in?

[Cacodemon345]

Vulkan. Though it happens with OpenGL too on ares.

[chyyran]

Could you check if #237 fixes the issue for you?

I can see koko-aio working on ares with this, 86Box seems to be statically linking librashader so I can't confirm there without setting up the build env.

[TheSystemGuy1337]

@chyyran , you should check Monitor-VGA-DoubleScan-ShadowMask as thats the exact shader I first reported the issue on back in 86Box/86Box#7370

[chyyran]

The issue seems to be with 86Box resetting the default runtime parameters of the shader to 0, which is why koko-aio has background bloom but nothing else showing. The PR makes it so that it sets the runtime defaults to what the preset specifies.

[Cacodemon345]

For the record, -DLIBRASHADER_STATIC=0 CMake flag on 86Box will enable dynamic linking again. We have to use static linking because Rust ignores settings to link the C++ STL statically on DLL builds.

[Juesto]

by default its set to not build statically, here's on macos with the pr:

[Cacodemon345]

The issue seems to be with 86Box resetting the default runtime parameters of the shader to 0, which is why koko-aio has background bloom but nothing else showing. The PR makes it so that it sets the runtime defaults to what the preset specifies.

This is correct. We offer options to configure shader parameters unlike ares, where it's still a pending feature request.

[chyyran]

It's the resetting to 0 that causes the shader to render improperly but the PR linked should properly set defaults. Can you check if it fixes the issue on your end?

[Cacodemon345]

It works.

[Cacodemon345]

[chyyran]

Merged the fix in, will do a release tomorrow (I need to cut 0.12.0 as well for wgpu 30 but that shouldn't affect C API users whatsoever)