Skip to content

Relax validator set id constraints#1729

Merged
yrong merged 3 commits into
mainfrom
relax-session-id-constraints
Mar 3, 2026
Merged

Relax validator set id constraints#1729
yrong merged 3 commits into
mainfrom
relax-session-id-constraints

Conversation

@vgeddes
Copy link
Copy Markdown
Collaborator

@vgeddes vgeddes commented Feb 27, 2026

Allow the candidate nextValidatorSet ID to be 1 or more than the current nextValidatorSet id.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (e7fa333) to head (5162a26).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1729      +/-   ##
==========================================
+ Coverage   75.20%   76.60%   +1.40%     
==========================================
  Files          24       24              
  Lines         996      979      -17     
  Branches      186      186              
==========================================
+ Hits          749      750       +1     
+ Misses        223      205      -18     
  Partials       24       24              
Flag Coverage Δ
solidity 76.60% <100.00%> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yrong
Copy link
Copy Markdown
Contributor

yrong commented Feb 27, 2026

So we're allowing non-continuous session ID switches — for example, (current,next) moving from (3,4) to (4,8). In that case,do we also want to allow a subsequent commitment whose validator set ID falls in between (e.g., 5)?

If that’s the case, the changes in this PR might not be sufficient, as this could also break other checks, such as:

} else if (commitment.validatorSetID == nextValidatorSet.id) {

This also reminds me of a previous PR:
#1137

@yrong yrong marked this pull request as ready for review March 3, 2026 11:13
Copy link
Copy Markdown
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yrong yrong merged commit da414f1 into main Mar 3, 2026
4 checks passed
@yrong yrong deleted the relax-session-id-constraints branch March 3, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants