Relax validator set id constraints#1729
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
+ Coverage 75.20% 76.60% +1.40%
==========================================
Files 24 24
Lines 996 979 -17
Branches 186 186
==========================================
+ Hits 749 750 +1
+ Misses 223 205 -18
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
So we're allowing non-continuous session ID switches — for example, (current,next) moving from (3,4) to (4,8). In that case,do we also want to allow a subsequent commitment whose validator set ID falls in between (e.g., 5)? If that’s the case, the changes in this PR might not be sufficient, as this could also break other checks, such as: snowbridge/contracts/src/BeefyClient.sol Line 293 in e7fa333 This also reminds me of a previous PR: |
Allow the candidate nextValidatorSet ID to be 1 or more than the current nextValidatorSet id.