test(coverage): spawn-sfw.mts to 100% (was 11.76%)

Adds 6 tests for the bespoke spawnSfwDlx flow:

- local-binary path uses the resolved local sfw

- local script path runs through node

- 'dlx' resolution type falls back to spawnDlx

- unexpected resolution type throws an internal error

- custom stdio in spawnExtra is honored

- empty args skip applyMachineModeIfActive

Vfs and auto-dispatch are tested via the shared define-tool-spawn factory tests.

Author: jdalton

.config/oxlint-plugin/rules/no-fetch-prefer-http-request.js

@@ -41,7 +41,7 @@ const rule = {
 
         // Skip if `fetch` is locally shadowed by a parameter / declaration.
         // Best-effort: check the scope chain.
-        const scope = context.getScope ? context.getScope() : null
+        const scope = context.getScope ? context.getScope() : undefined
         if (scope) {
           const variable = scope.references.find(
             ref => ref.identifier === callee,

.config/oxlint-plugin/rules/no-promise-race-in-loop.js

@@ -20,15 +20,9 @@
  * Reporting only.
  */
 
-const RACE_METHODS = new Set(['race', 'any'])
+const RACE_METHODS = new Set(['any', 'race'])
 
-const LOOP_TYPES = new Set([
-  'ForStatement',
-  'ForOfStatement',
-  'ForInStatement',
-  'WhileStatement',
-  'DoWhileStatement',
-])
+const LOOP_TYPES = new Set(['DoWhileStatement', 'ForInStatement', 'ForOfStatement', 'ForStatement', 'WhileStatement'])
 
 function isInsideLoop(node) {
   let current = node.parent

.config/oxlint-plugin/rules/no-status-emoji.js

@@ -60,7 +60,7 @@ const rule = {
           return emoji
         }
       }
-      return null
+      return undefined
     }
 
     /**
@@ -71,7 +71,7 @@ const rule = {
     function leadingEmoji(value) {
       const match = EMOJI_LEAD_RE.exec(value)
       if (!match) {
-        return null
+        return undefined
       }
       return {
         emoji: match[1],
@@ -86,30 +86,30 @@ const rule = {
     function tryFix(node, literalNode, leadInfo) {
       const method = EMOJI_TO_METHOD[leadInfo.emoji]
       if (!method) {
-        return null
+        return undefined
       }
 
       // Only fix when the parent is a CallExpression and the literal
       // is the first argument. Otherwise leave to the human.
       const parent = node.parent
       if (!parent || parent.type !== 'CallExpression') {
-        return null
+        return undefined
       }
       if (parent.arguments[0] !== literalNode) {
-        return null
+        return undefined
       }
 
       const callee = parent.callee
       if (callee.type !== 'MemberExpression') {
-        return null
+        return undefined
       }
 
       const objectName =
-        callee.object.type === 'Identifier' ? callee.object.name : null
+        callee.object.type === 'Identifier' ? callee.object.name : undefined
       const propName =
-        callee.property.type === 'Identifier' ? callee.property.name : null
+        callee.property.type === 'Identifier' ? callee.property.name : undefined
       if (!objectName || !propName) {
-        return null
+        return undefined
       }
 
       const isConsole =
@@ -119,7 +119,7 @@ const rule = {
         objectName === 'logger' && (propName === 'log' || propName === 'info')
 
       if (!isConsole && !isLoggerLog) {
-        return null
+        return undefined
       }
 
       // Build the replacement.
@@ -133,7 +133,7 @@ const rule = {
     }
 
     function reportLiteral(node) {
-      const value = typeof node.value === 'string' ? node.value : null
+      const value = typeof node.value === 'string' ? node.value : undefined
       if (!value) {
         return
       }
@@ -144,7 +144,7 @@ const rule = {
       }
 
       const leadInfo = leadingEmoji(value)
-      const method = leadInfo ? EMOJI_TO_METHOD[leadInfo.emoji] : null
+      const method = leadInfo ? EMOJI_TO_METHOD[leadInfo.emoji] : undefined
 
       if (leadInfo && method) {
         const fix = tryFix(node, node, leadInfo)

.config/oxlint-plugin/rules/prefer-exists-sync.js

@@ -19,7 +19,7 @@
  */
 
 const ACCESS_METHODS = new Set(['access', 'accessSync'])
-const STAT_METHODS = new Set(['stat', 'statSync', 'lstat', 'lstatSync'])
+const STAT_METHODS = new Set(['lstat', 'lstatSync', 'stat', 'statSync'])
 
 /** @type {import('eslint').Rule.RuleModule} */
 const rule = {
@@ -44,10 +44,10 @@ const rule = {
   create(context) {
     function calleeMethodName(callee) {
       if (callee.type !== 'MemberExpression') {
-        return null
+        return undefined
       }
       if (callee.property.type !== 'Identifier') {
-        return null
+        return undefined
       }
       return callee.property.name
     }

.config/oxlint-plugin/rules/prefer-safe-delete.js

@@ -17,14 +17,7 @@
  * (`.claude/hooks/path-guard/`) — this rule covers the JavaScript side.
  */
 
-const DELETE_METHODS = new Set([
-  'rm',
-  'rmSync',
-  'unlink',
-  'unlinkSync',
-  'rmdir',
-  'rmdirSync',
-])
+const DELETE_METHODS = new Set(['rm', 'rmSync', 'rmdir', 'rmdirSync', 'unlink', 'unlinkSync'])
 
 /** @type {import('eslint').Rule.RuleModule} */
 const rule = {
@@ -69,7 +62,7 @@ const rule = {
             : obj.type === 'MemberExpression' &&
                 obj.property.type === 'Identifier'
               ? obj.property.name
-              : null
+              : undefined
 
         if (!objName) {
           return

.config/oxlint-plugin/rules/sort-set-args.js

@@ -10,7 +10,7 @@
  * but not auto-fixed (sorting computed values would change behavior).
  */
 
-const SET_NAMES = new Set(['Set', 'SafeSet'])
+const SET_NAMES = new Set(['SafeSet', 'Set'])
 
 function isSortableElement(node) {
   return (

.config/oxlint-plugin/rules/sort-source-methods.js

@@ -41,7 +41,7 @@ function declVisibility(node) {
   if (node.type === 'FunctionDeclaration') {
     return { visibility: 'private', fn: node }
   }
-  return null
+  return undefined
 }
 
 /** @type {import('eslint').Rule.RuleModule} */
@@ -67,8 +67,8 @@ const rule = {
     return {
       Program(programNode) {
         let lastVisibilityRank = -1
-        let lastNameInGroup = null
-        let currentVisibility = null
+        let lastNameInGroup = undefined
+        let currentVisibility = undefined
 
         for (const node of programNode.body) {
           const info = declVisibility(node)

.git-hooks/pre-push.mts

@@ -100,10 +100,10 @@ const computeRange = (
 ): string | null => {
   if (localRef.startsWith('refs/tags/')) {
     logger.info(`Skipping tag push: ${localRef}`)
-    return null
+    return undefined
   }
   if (localSha === ZERO_SHA) {
-    return null
+    return undefined
   }
 
   const defaultBranchOf = (remoteName: string): string => {
@@ -132,7 +132,7 @@ const computeRange = (
     const baseRef = `${remote}/${def}`
     if (!refExists(baseRef)) {
       logger.success('Skipping validation (no baseline to compare against)')
-      return null
+      return undefined
     }
     return `${baseRef}..${localSha}`
   }
@@ -144,7 +144,7 @@ const computeRange = (
     const baseRef = `${remote}/${def}`
     if (!refExists(baseRef)) {
       logger.success('Skipping validation (no baseline for force-push)')
-      return null
+      return undefined
     }
     return `${baseRef}..${localSha}`
   }

.oxlintrc.json

@@ -1,16 +1,44 @@
 {
   "$schema": "https://raw.githubusercontent.com/oxc-project/oxc/main/npm/oxlint/configuration_schema.json",
-  "plugins": ["typescript", "unicorn", "import"],
+  "plugins": [
+    "typescript",
+    "unicorn",
+    "import"
+  ],
+  "jsPlugins": [
+    "./.config/oxlint-plugin/index.js"
+  ],
   "categories": {
     "correctness": "error",
     "suspicious": "error"
   },
   "rules": {
-    "eslint/curly": ["error", "all"],
+    "socket/export-top-level-functions": "error",
+    "socket/no-console-prefer-logger": "error",
+    "socket/no-dynamic-import-outside-bundle": "error",
+    "socket/no-fetch-prefer-http-request": "error",
+    "socket/no-inline-logger": "error",
+    "socket/no-promise-race-in-loop": "error",
+    "socket/no-status-emoji": "error",
+    "socket/no-todo-comments": "error",
+    "socket/prefer-exists-sync": "error",
+    "socket/prefer-safe-delete": "error",
+    "socket/prefer-undefined-over-null": "error",
+    "socket/sort-set-args": "error",
+    "socket/sort-source-methods": "error",
+    "eslint/curly": [
+      "error",
+      "all"
+    ],
     "eslint/no-await-in-loop": "off",
     "eslint/no-console": "off",
     "eslint/no-control-regex": "off",
-    "eslint/no-empty": ["error", { "allowEmptyCatch": true }],
+    "eslint/no-empty": [
+      "error",
+      {
+        "allowEmptyCatch": true
+      }
+    ],
     "eslint/no-new": "error",
     "eslint/no-unmodified-loop-condition": "off",
     "eslint/no-useless-catch": "off",
@@ -26,15 +54,27 @@
     "import/no-named-as-default-member": "off",
     "import/no-self-import": "error",
     "import/no-unassigned-import": "off",
-    "typescript/array-type": ["error", { "default": "array-simple" }],
+    "typescript/array-type": [
+      "error",
+      {
+        "default": "array-simple"
+      }
+    ],
     "typescript/no-extraneous-class": "off",
     "typescript/consistent-type-assertions": [
       "error",
-      { "assertionStyle": "as" }
+      {
+        "assertionStyle": "as"
+      }
     ],
     "typescript/no-misused-new": "error",
     "typescript/no-non-null-asserted-optional-chain": "off",
-    "typescript/no-this-alias": ["error", { "allowDestructuring": true }],
+    "typescript/no-this-alias": [
+      "error",
+      {
+        "allowDestructuring": true
+      }
+    ],
     "unicorn/consistent-function-scoping": "off",
     "unicorn/no-array-for-each": "off",
     "unicorn/no-array-sort": "off",

packages/build-infra/lib/github-releases.mts

@@ -128,7 +128,7 @@ export async function getLatestRelease(
             if (!quiet) {
               logger.info(`  No releases found for ${owner}/${repo}`)
             }
-            return null
+            return undefined
           }
           const tag = releases[0].tag_name
           if (!quiet) {
@@ -152,7 +152,7 @@ export async function getLatestRelease(
         if (!quiet) {
           logger.info(`  No ${prefix} release found in latest 100 releases`)
         }
-        return null
+        return undefined
       },
       {
         backoffFactor: 2,