fix(test): replace runCommandQuiet with spawn and fix mock constructors

- Replace all runCommandQuiet calls with spawn from @socketsecurity/lib/spawn
- Add proper spawn configuration (cwd, encoding, shell: WIN32, stdio)
- Fix npm config test mocks to use function() instead of arrow functions
- Fix undefined variable references (code → exitCode)
- Add missing imports (WIN32, spawn) to check.mjs and cover.mjs

Test improvements:
- Fixed 12 npm config test failures
- Tests now run without "runCommandQuiet is not defined" errors
- Test results: 27 failed, 2780 passed (down from 39 failed, 2768 passed)

Author: jdalton

packages/cli/scripts/check.mjs

@@ -4,7 +4,9 @@
  */
 
 import { parseArgs } from '@socketsecurity/lib/argv/parse'
+import { WIN32 } from '@socketsecurity/lib/constants/platform'
 import { logger } from '@socketsecurity/lib/logger'
+import { spawn } from '@socketsecurity/lib/spawn'
 import { printFooter, printHeader } from '@socketsecurity/lib/stdio/header'
 
 /**
@@ -31,7 +33,12 @@ async function runEslintCheck(options = {}) {
     args.push('--changed')
   }
 
-  const result = await runCommandQuiet('pnpm', args)
+  const result = await spawn('pnpm', args, {
+    cwd: process.cwd(),
+    encoding: 'utf8',
+    shell: WIN32,
+    stdio: ['pipe', 'pipe', 'pipe'],
+  })
 
   if (result.code !== 0) {
     if (!quiet) {
@@ -65,7 +72,12 @@ async function runTypeCheck(options = {}) {
     logger.progress('Checking TypeScript')
   }
 
-  const result = await runCommandQuiet('pnpm', ['run', 'type'])
+  const result = await spawn('pnpm', ['run', 'type'], {
+    cwd: process.cwd(),
+    encoding: 'utf8',
+    shell: WIN32,
+    stdio: ['pipe', 'pipe', 'pipe'],
+  })
 
   if (result.code !== 0) {
     if (!quiet) {
@@ -171,7 +183,7 @@ async function main() {
         quiet,
         staged: values.staged,
       })
-      if (code !== 0) {
+      if (exitCode !== 0) {
         if (!quiet) {
           logger.error('Checks failed')
         }
@@ -183,7 +195,7 @@ async function main() {
     // Run TypeScript check if requested or running all
     if (runAll || values.types) {
       exitCode = await runTypeCheck({ quiet })
-      if (code !== 0) {
+      if (exitCode !== 0) {
         if (!quiet) {
           logger.error('Checks failed')
         }

packages/cli/scripts/cover.mjs

@@ -84,8 +84,13 @@ async function main() {
 
     // Handle --type-only flag
     if (values['type-only']) {
-      typeCoverageResult = await runCommandQuiet('pnpm', typeCoverageArgs)
-      exitCode = typeCoverageResult.exitCode
+      typeCoverageResult = await spawn('pnpm', typeCoverageArgs, {
+        cwd: process.cwd(),
+        encoding: 'utf8',
+        shell: WIN32,
+        stdio: ['pipe', 'pipe', 'pipe'],
+      })
+      exitCode = typeCoverageResult.code
 
       if (!quiet) {
         // Display type coverage only
@@ -121,8 +126,13 @@ async function main() {
 
     // Handle --code-only flag
     if (values['code-only']) {
-      codeCoverageResult = await runCommandQuiet('pnpm', vitestArgs)
-      exitCode = codeCoverageResult.exitCode
+      codeCoverageResult = await spawn('pnpm', vitestArgs, {
+        cwd: process.cwd(),
+        encoding: 'utf8',
+        shell: WIN32,
+        stdio: ['pipe', 'pipe', 'pipe'],
+      })
+      exitCode = codeCoverageResult.code
 
       if (!quiet) {
         // Process code coverage output only
@@ -169,7 +179,7 @@ async function main() {
           logger.log(' ───────────────────────────────')
           logger.log(` Code Coverage: ${codeCoveragePercent.toFixed(2)}%`)
           logger.log('')
-        } else if (code !== 0) {
+        } else if (exitCode !== 0) {
           logger.log('\n--- Output ---')
           logger.log(output)
         }
@@ -189,11 +199,21 @@ async function main() {
     }
 
     // Default: run both code and type coverage
-    codeCoverageResult = await runCommandQuiet('pnpm', vitestArgs)
-    exitCode = codeCoverageResult.exitCode
+    codeCoverageResult = await spawn('pnpm', vitestArgs, {
+      cwd: process.cwd(),
+      encoding: 'utf8',
+      shell: WIN32,
+      stdio: ['pipe', 'pipe', 'pipe'],
+    })
+    exitCode = codeCoverageResult.code
 
     // Run type coverage
-    typeCoverageResult = await runCommandQuiet('pnpm', typeCoverageArgs)
+    typeCoverageResult = await spawn('pnpm', typeCoverageArgs, {
+      cwd: process.cwd(),
+      encoding: 'utf8',
+      shell: WIN32,
+      stdio: ['pipe', 'pipe', 'pipe'],
+    })
 
     // Combine and clean output - remove ANSI color codes and spinner artifacts
     const ansiRegex = new RegExp(`${String.fromCharCode(27)}\\[[0-9;]*m`, 'g')
@@ -261,7 +281,7 @@ async function main() {
       }
     }
 
-    if (code !== 0) {
+    if (exitCode !== 0) {
       if (!quiet) {
         printError('Coverage failed')
         // Show relevant output on failure for debugging

packages/cli/src/utils/npm/config.test.mts

@@ -11,7 +11,9 @@ const { MockNpmConfig, mockNpmConfigInstance } = vi.hoisted(() => {
     },
   }
 
-  const MockNpmConfig = vi.fn().mockImplementation(() => mockNpmConfigInstance)
+  const MockNpmConfig = vi.fn().mockImplementation(function () {
+    return mockNpmConfigInstance
+  })
 
   return { MockNpmConfig, mockNpmConfigInstance }
 })
@@ -135,10 +137,12 @@ describe('npm-config utilities', () => {
     it('calls config.load()', async () => {
       const mockLoad = vi.fn().mockResolvedValue(undefined)
       vi.mocked((await import('@npmcli/config')).default).mockImplementation(
-        (() => ({
-          load: mockLoad,
-          flat: { test: 'value' },
-        })) as any,
+        (function () {
+          return {
+            load: mockLoad,
+            flat: { test: 'value' },
+          }
+        }) as any,
       )
 
       await getNpmConfig()

scripts/test-monorepo.mjs

@@ -77,10 +77,15 @@ async function runPackageTest(pkg, testArgs = [], quiet = false) {
     logger.progress(`${displayName}: running tests`)
   }
 
-  const result = await runCommandQuiet(
+  const result = await spawn(
     'pnpm',
     ['--filter', pkg.name, 'run', 'test', ...testArgs],
-    { cwd: process.cwd() },
+    {
+      cwd: process.cwd(),
+      encoding: 'utf8',
+      shell: WIN32,
+      stdio: ['pipe', 'pipe', 'pipe'],
+    },
   )
 
   if (result.code !== 0) {
@@ -178,7 +183,7 @@ async function main() {
       }
     }
 
-    if (code !== 0) {
+    if (exitCode !== 0) {
       if (!quiet) {
         logger.error('')
         logger.log('Tests failed')