Don't try to open a PR if there are no changed files

Author: jdalton

src/commands/fix/git.ts

@@ -120,10 +120,9 @@ export async function gitCreateAndPushBranchIfNeeded(
   cwd = process.cwd()
 ): Promise<boolean> {
   if (await gitBranchExists(branch, cwd)) {
-    logger.warn(`Branch "${branch}" already exists. Skipping creation.`)
-    return false
+    logger.warn(`Branch "${branch}" already exists, skipping creation.`)
+    return true
   }
-  await spawn('git', ['checkout', '-b', branch], { cwd })
   const moddedFilepaths = (await gitUnstagedModifiedFiles(cwd)).filter(p => {
     const basename = path.basename(p)
     return (
@@ -132,9 +131,12 @@ export async function gitCreateAndPushBranchIfNeeded(
       basename === 'pnpm-lock.yaml'
     )
   })
-  if (moddedFilepaths.length) {
-    await spawn('git', ['add', ...moddedFilepaths], { cwd })
+  if (!moddedFilepaths.length) {
+    logger.warn('Nothing to commit, skipping push.')
+    return false
   }
+  await spawn('git', ['checkout', '-b', branch], { cwd })
+  await spawn('git', ['add', ...moddedFilepaths], { cwd })
   await spawn('git', ['commit', '-m', commitMsg], { cwd })
   await spawn('git', ['push', '--set-upstream', 'origin', branch], { cwd })
   return true

src/commands/fix/npm-fix.ts

@@ -279,13 +279,16 @@ export async function npmFix(
             errored = true
           }
 
-          if (!errored && shouldOpenPr) {
+          if (
+            !errored &&
+            shouldOpenPr &&
             // eslint-disable-next-line no-await-in-loop
-            await gitCreateAndPushBranchIfNeeded(
+            (await gitCreateAndPushBranchIfNeeded(
               branch,
               getSocketCommitMessage(oldPurl, newVersion, workspaceName),
               cwd
-            )
+            ))
+          ) {
             // eslint-disable-next-line no-await-in-loop
             const prResponse = await openGitHubPullRequest(
               owner,

src/commands/fix/pnpm-fix.ts

@@ -340,13 +340,16 @@ export async function pnpmFix(
             errored = true
           }
 
-          if (!errored && shouldOpenPr) {
+          if (
+            !errored &&
+            shouldOpenPr &&
             // eslint-disable-next-line no-await-in-loop
-            await gitCreateAndPushBranchIfNeeded(
+            (await gitCreateAndPushBranchIfNeeded(
               branch,
               getSocketCommitMessage(oldPurl, newVersion, workspaceName),
               cwd
-            )
+            ))
+          ) {
             // eslint-disable-next-line no-await-in-loop
             const prResponse = await openGitHubPullRequest(
               owner,