fix(bootstrap): eliminate spurious error message on successful CLI execution

Resolves issue where "Bootstrap error: command failed" was printed after
every command execution, even when commands succeeded.

Root cause: Calling process.exit() inside async functions can trigger
promise rejections during Node.js shutdown, causing the catch block to
fire spuriously.

Solution: Return exit codes from async functions and call process.exit()
at the top level after all async operations complete cleanly.

Changes:
- executeCli(): Return exit code instead of calling process.exit()
- findAndExecuteCli(): Propagate exit code from executeCli()
- bootstrap-smol.mts: Call process.exit() in .then() handler
- bootstrap-npm.mts: Same fix for npm wrapper
- bootstrap-sea.mts: Same fix for SEA binary

Fixes affect all three bootstrap variants to ensure consistency.

Author: jdalton

packages/bootstrap/dist/bootstrap-npm.js

@@ -14,11 +14,16 @@ import { findAndExecuteCli, getArgs } from './shared/bootstrap-shared.mjs'
 
 async function main() {
   const args = getArgs()
-  await findAndExecuteCli(args)
+  return await findAndExecuteCli(args)
 }
 
 // Run the bootstrap.
-main().catch((e) => {
-  logger.error(`Bootstrap error: ${e instanceof Error ? e.message : String(e)}`)
-  process.exit(1)
-})
+main()
+  .then((exitCode) => {
+    // Exit with the code returned by the CLI.
+    process.exit(exitCode)
+  })
+  .catch((e) => {
+    logger.error(`Bootstrap error: ${e instanceof Error ? e.message : String(e)}`)
+    process.exit(1)
+  })

packages/bootstrap/dist/bootstrap-smol.js

@@ -15,12 +15,17 @@ import { findAndExecuteCli, getArgs } from './shared/bootstrap-shared.mjs'
 
 async function main() {
   const args = getArgs()
-  await findAndExecuteCli(args)
+  return await findAndExecuteCli(args)
 }
 
 // Run the bootstrap.
-main().catch((e) => {
-  // Use process.stderr.write() directly to avoid console access during early bootstrap.
-  process.stderr.write(`Bootstrap error: ${e instanceof Error ? e.message : String(e)}\n`)
-  process.exit(1)
-})
+main()
+  .then((exitCode) => {
+    // Exit with the code returned by the CLI.
+    process.exit(exitCode)
+  })
+  .catch((e) => {
+    // Use process.stderr.write() directly to avoid console access during early bootstrap.
+    process.stderr.write(`Bootstrap error: ${e instanceof Error ? e.message : String(e)}\n`)
+    process.exit(1)
+  })

packages/bootstrap/src/bootstrap-npm.mts

@@ -14,17 +14,18 @@ import { findAndExecuteCli, getArgs } from './shared/bootstrap-shared.mjs'
 
 async function main() {
   const args = getArgs()
-  await findAndExecuteCli(args)
+  return await findAndExecuteCli(args)
 }
 
 // Run the bootstrap.
-main().catch((e) => {
-  // Suppress spurious "command failed" error from process.exit() during CLI execution.
-  const errorMsg = e instanceof Error ? e.message : String(e)
-  if (errorMsg.includes('command failed')) {
-    return
-  }
-  // Use process.stderr.write() directly to avoid console access during early bootstrap.
-  process.stderr.write(`Bootstrap error: ${errorMsg}\n`)
-  process.exit(1)
-})
+main()
+  .then((exitCode) => {
+    // Exit with the code returned by the CLI.
+    process.exit(exitCode)
+  })
+  .catch((e) => {
+    // Use process.stderr.write() directly to avoid console access during early bootstrap.
+    const errorMsg = e instanceof Error ? e.message : String(e)
+    process.stderr.write(`Bootstrap error: ${errorMsg}\n`)
+    process.exit(1)
+  })

packages/bootstrap/src/bootstrap-sea.mts

@@ -150,7 +150,7 @@ export async function executeCli(cliPath, args) {
     })
   }
 
-  process.exit(result.code ?? 0)
+  return result.code ?? 0
 }
 
 /**
@@ -199,6 +199,7 @@ export async function downloadCli() {
 
 /**
  * Find and execute the CLI from the downloaded package.
+ * Returns exit code from CLI execution.
  */
 export async function findAndExecuteCli(args) {
   // Download CLI if needed.
@@ -210,12 +211,12 @@ export async function findAndExecuteCli(args) {
 
   // Execute the CLI loader.
   if (existsSync(cliEntry)) {
-    await executeCli(cliEntry, args)
+    return await executeCli(cliEntry, args)
   }
 
   // If we can't find the CLI, exit with error.
   logger.error('Socket CLI installation failed')
   logger.error('   CLI entry point not found after installation')
   logger.error(`   Looked in: ${cliEntry}`)
-  process.exit(1)
+  return 1
 }