refactor(scripts): prefer undefined over null for absent values

Author: jdalton

scripts/babel/babel-plugin-strict-mode.mjs

@@ -22,13 +22,13 @@
 /**
  * Convert legacy octal literal (0123) to decimal number
  * @param {string} value - The numeric literal string
- * @returns {number|null} Decimal value or null if not octal
+ * @returns {number|undefined} Decimal value or undefined if not octal
  */
 function convertOctalLiteral(value) {
   // Match legacy octal: starts with 0, followed by octal digits (0-7)
   const octalMatch = /^0([0-7]+)$/.exec(value)
   if (!octalMatch) {
-    return null
+    return undefined
   }
 
   const octalDigits = octalMatch[1]

scripts/build.mjs

@@ -67,14 +67,14 @@ const BUILD_PACKAGES = [
  */
 function parseArgs() {
   const args = process.argv.slice(2)
-  let target = null
+  let target
   let targets = []
   let platforms = false
   let parallel = false
   let force = false
   let help = false
-  let platform = null
-  let arch = null
+  let platform
+  let arch
   const buildArgs = []
 
   for (let i = 0; i < args.length; i++) {

scripts/lib/patch-validator.mjs

@@ -179,7 +179,7 @@ export function analyzePatchContent(patchContent) {
   }
 
   const lines = patchContent.split('\n')
-  let currentFile = null
+  let currentFile
 
   for (const line of lines) {
     // Track which files are modified.

scripts/setup.mjs

@@ -98,15 +98,15 @@ async function getVersion(command, args = ['--version']) {
   } catch {
     // Ignore.
   }
-  return null
+  return undefined
 }
 
 /**
  * Parse version string to compare.
  */
 function parseVersion(versionString) {
   const match = versionString.match(/(\d+)\.(\d+)\.(\d+)/)
-  if (!match) {return null}
+  if (!match) {return undefined}
   return {
     major: Number.parseInt(match[1], 10),
     minor: Number.parseInt(match[2], 10),

scripts/test-monorepo.mjs

@@ -204,7 +204,7 @@ async function main() {
     }
 
     // Setup progress bar.
-    let progressBar = null
+    let progressBar
     if (!quiet && packages.length > 1) {
       progressBar = new ProgressBar(packages.length, {
         format: ':bar :percent :current/:total :pkg',

scripts/update-socketbin-versions.mjs

@@ -21,7 +21,7 @@ async function getLatestVersion(packageName) {
     return result.stdout.trim()
   } catch (error) {
     console.error(`Failed to get version for ${packageName}:`, error.message)
-    return null
+    return undefined
   }
 }
 

scripts/validate-bundle-deps.mjs

@@ -130,12 +130,12 @@ async function extractBundledPackages(filePath) {
 function getPackageName(specifier) {
   // Relative imports are not packages
   if (specifier.startsWith('.') || specifier.startsWith('/')) {
-    return null
+    return undefined
   }
 
   // Subpath imports (Node.js internal imports starting with #)
   if (specifier.startsWith('#')) {
-    return null
+    return undefined
   }
 
   // Filter out template strings, boolean strings, and other non-package patterns
@@ -160,7 +160,7 @@ function getPackageName(specifier) {
     specifier.includes("'") ||
     specifier.includes('\\')
   ) {
-    return null
+    return undefined
   }
 
   // Scoped package: @scope/package or @scope/package/subpath
@@ -169,7 +169,7 @@ function getPackageName(specifier) {
     if (parts.length >= 2) {
       return `${parts[0]}/${parts[1]}`
     }
-    return null
+    return undefined
   }
 
   // Regular package: package or package/subpath