Skip to content

Commit 18731d6

Browse files
committed
fix(sea): repoint build-sea/test-sea imports at sea-build-utils dir
build-sea.mts and test-sea.mts imported ./sea-build-util/* (singular), but the directory on disk is sea-build-utils (plural) — node resolution failed with ERR_MODULE_NOT_FOUND, so the SEA build/test path was broken. Repoint the four real imports (and asset-manager-compat's dynamic import) to the plural name, refresh the stale doc-comment references, and drop a TODO the touched function carried.
1 parent d6b7f37 commit 18731d6

5 files changed

Lines changed: 11 additions & 13 deletions

File tree

packages/cli/scripts/build-sea.mts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ import { getDefaultLogger } from '@socketsecurity/lib-stable/logger/default'
2222
import { parsePlatformArgs } from 'build-infra/lib/platform-targets'
2323
import { getSocketbinBinaryPath } from 'package-builder/scripts/paths.mts'
2424

25-
import { buildTarget } from './sea-build-util/orchestration.mts'
25+
import { buildTarget } from './sea-build-utils/orchestration.mts'
2626
import {
2727
getBuildTargets,
2828
getDefaultNodeVersion,
29-
} from './sea-build-util/targets.mts'
29+
} from './sea-build-utils/targets.mts'
3030

3131
const __dirname = path.dirname(fileURLToPath(import.meta.url))
3232
const rootPath = path.join(__dirname, '..')

packages/cli/scripts/test-sea.mts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -412,8 +412,8 @@ async function runWithToolsMode(platform, toolPaths) {
412412

413413
// Dynamic import Socket modules.
414414
const { getDefaultLogger } = await import('@socketsecurity/lib-stable/logger')
415-
const { injectSeaBlob } = await import('./sea-build-util/builder.mts')
416-
const { downloadNodeBinary } = await import('./sea-build-util/downloads.mts')
415+
const { injectSeaBlob } = await import('./sea-build-utils/builder.mts')
416+
const { downloadNodeBinary } = await import('./sea-build-utils/downloads.mts')
417417

418418
const logger = getDefaultLogger()
419419
const totalToolSize = await displayToolInfo(toolPaths)

packages/cli/scripts/util/asset-manager-compat.mts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* @file Backward-compatible wrappers for AssetManager. Maintains existing API
3-
* signatures from sea-build-util/downloads.mts while using the unified
3+
* signatures from sea-build-utils/downloads.mts while using the unified
44
* AssetManager internally. Phase 1 of AssetManager migration - provides
55
* drop-in replacements without modifying existing code.
66
*/
@@ -83,7 +83,7 @@ const assetManager = new AssetManager({
8383

8484
/**
8585
* Download Node.js binary for a specific platform (backward-compatible
86-
* wrapper). Maintains exact API signature from sea-build-util/downloads.mts.
86+
* wrapper). Maintains exact API signature from sea-build-utils/downloads.mts.
8787
*
8888
* @example
8989
* const nodePath = await downloadNodeBinary('20251213-7cf90d2', 'darwin', 'arm64')
@@ -111,7 +111,7 @@ export async function downloadNodeBinary(version, platform, arch, libc) {
111111

112112
/**
113113
* Download binject binary for the current platform (backward-compatible
114-
* wrapper). Maintains exact API signature from sea-build-util/downloads.mts.
114+
* wrapper). Maintains exact API signature from sea-build-utils/downloads.mts.
115115
*
116116
* @example
117117
* const binjectPath = await downloadBinject('1.0.0')
@@ -142,7 +142,7 @@ export async function downloadBinject(version) {
142142
* string (e.g., "1.0.0").
143143
*
144144
* Note: This function currently delegates to the original implementation in
145-
* sea-build-util/downloads.mts. Future enhancement: move to AssetManager.
145+
* sea-build-utils/downloads.mts. Future enhancement: move to AssetManager.
146146
*
147147
* @example
148148
* const version = await getLatestBinjectVersion()
@@ -153,9 +153,7 @@ export async function downloadBinject(version) {
153153
* @throws {Error} When socket-btm releases cannot be fetched.
154154
*/
155155
export async function getLatestBinjectVersion() {
156-
// Delegate to original implementation for now.
157-
// TODO: Move this to AssetManager in Phase 4.
158156
const { getLatestBinjectVersion: getLatest } =
159-
await import('../sea-build-util/downloads.mts')
157+
await import('../sea-build-utils/downloads.mts')
160158
return getLatest()
161159
}

packages/cli/scripts/util/asset-manager.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* @file Unified asset manager for socket-btm releases. Consolidates download
3-
* functionality from download-assets.mts and sea-build-util/downloads.mts.
3+
* functionality from download-assets.mts and sea-build-utils/downloads.mts.
44
* This module provides:
55
*
66
* - Unified binary downloads (node-smol, binject)

packages/cli/src/util/dlx/vfs-extract.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*
1616
* Build-time package preparation: npm packages use @npmcli/arborist to download
1717
* complete packages with node_modules/ and all production dependencies. See
18-
* scripts/sea-build-util/npm-packages.mts:
18+
* scripts/sea-build-utils/npm-packages.mts:
1919
*
2020
* ```javascript
2121
* import { Arborist } from '@npmcli/arborist'

0 commit comments

Comments
 (0)