fix(build): fix runtime bugs in build scripts (#1148)

- Fix plugin ordering in esbuild.cli.build.mjs: envVarReplacementPlugin
  was running before unicodeTransformPlugin despite comment saying after.
  Swap order so unicode transform runs first.
- Fix watch mode crash in build.mjs: watchResult?.code can be undefined
  when spawn returns null. Add null check and fallback ?? 1.
- Fix allSettled pattern in build.mjs post-processing: Promise.all
  swallows individual rejections. Switch to Promise.allSettled with
  proper rejection detection.
- Fix allSettled pattern in download-assets.mjs: same Promise.all issue,
  now uses Promise.allSettled with r.status === 'rejected' check.
- Fix allSettled pattern in download-iocraft-binaries.mjs: same fix.
- Fix createBuildRunner in esbuild-shared.mjs: catch block never
  rethrew, so callers using allSettled could not detect failures.
- Remove dead script entries from cli/package.json (e2e:smol,
  build:sea:internal:bootstrap, publish:sea).

Author: jdalton

packages/cli/.config/esbuild.cli.build.mjs

@@ -101,9 +101,9 @@ const config = {
 
   // Handle special cases with plugins.
   plugins: [
+    unicodeTransformPlugin(),
     // Environment variable replacement must run AFTER unicode transform.
     envVarReplacementPlugin(inlinedEnvVars),
-    unicodeTransformPlugin(),
     {
       name: 'resolve-socket-lib-internals',
       setup(build) {

packages/cli/package.json

@@ -23,10 +23,8 @@
     "build:watch": "node --max-old-space-size=8192 --import=./scripts/load.mjs scripts/build.mjs --watch",
     "restore-cache": "node --import=./scripts/load.mjs scripts/restore-cache.mjs",
     "build:sea": "node --max-old-space-size=8192 --import=./scripts/load.mjs scripts/build-sea.mjs",
-    "build:sea:internal:bootstrap": "node --max-old-space-size=8192 .config/esbuild.sea-bootstrap.build.mjs",
     "build:js": "node scripts/build-js.mjs",
     "dev:watch": "pnpm run build:watch",
-    "publish:sea": "node --import=./scripts/load.mjs scripts/publish-sea.mjs",
     "check": "node ../../scripts/check.mjs",
     "check-ci": "pnpm run check",
     "lint": "oxlint -c ../../.oxlintrc.json",
@@ -52,7 +50,6 @@
     "dev:npx": "cross-env SOCKET_CLI_MODE=npx node --experimental-strip-types src/cli-dispatch.mts",
     "e2e-tests": "dotenvx -q run -f .env.test -- vitest run --config vitest.e2e.config.mts",
     "e2e:js": "node scripts/e2e.mjs --js",
-    "e2e:smol": "node scripts/e2e.mjs --smol",
     "e2e:sea": "node scripts/e2e.mjs --sea",
     "e2e:all": "node scripts/e2e.mjs --all",
     "test": "run-s check test:*",

packages/cli/scripts/build.mjs

@@ -141,9 +141,9 @@ async function main() {
       },
     )
 
-    if (watchResult.code !== 0) {
-      process.exitCode = watchResult.code
-      throw new Error(`Watch mode failed with exit code ${watchResult.code}`)
+    if (!watchResult || watchResult.code !== 0) {
+      process.exitCode = watchResult?.code ?? 1
+      throw new Error(`Watch mode failed with exit code ${watchResult?.code ?? 1}`)
     }
     return
   }
@@ -265,7 +265,7 @@ async function main() {
       logger.step('Phase 4: Post-processing (parallel)...')
     }
 
-    await Promise.all([
+    const postResults = await Promise.allSettled([
       // Copy CLI bundle to dist (required for dist/index.js to work).
       (async () => {
         copyFileSync('build/cli.js', 'dist/cli.js')
@@ -297,6 +297,14 @@ async function main() {
       })(),
     ])
 
+    const postFailed = postResults.filter(r => r.status === 'rejected')
+    if (postFailed.length > 0) {
+      for (const r of postFailed) {
+        logger.error(`Post-processing failed: ${r.reason?.message ?? r.reason}`)
+      }
+      throw new Error('Post-processing step(s) failed')
+    }
+
     if (!quiet) {
       printSuccess('Build completed')
       printFooter()

packages/cli/scripts/download-assets.mjs

@@ -331,15 +331,19 @@ ${content}
  */
 async function downloadAssets(assetNames, parallel = true) {
   if (parallel) {
-    const results = await Promise.all(
+    const settled = await Promise.allSettled(
       assetNames.map(name => downloadAsset(ASSETS[name])),
     )
 
-    const failed = results.filter(r => !r.ok)
+    const failed = settled.filter(
+      r => r.status === 'rejected' || (r.status === 'fulfilled' && !r.value.ok),
+    )
     if (failed.length > 0) {
       logger.error(`\n${failed.length} asset(s) failed:`)
-      for (const { name } of failed) {
-        logger.error(`  - ${name}`)
+      for (const r of failed) {
+        logger.error(
+          `  - ${r.status === 'rejected' ? r.reason?.message ?? r.reason : r.value.name}`,
+        )
       }
       process.exitCode = 1
     }

scripts/download-iocraft-binaries.mjs

@@ -154,15 +154,17 @@ async function downloadBinaries(platformFilter = null) {
     `Downloading iocraft binaries for ${configs.length} platform(s)...`,
   )
 
-  const results = await Promise.all(
+  const settled = await Promise.allSettled(
     configs.map(config => downloadIocraftBinary(config)),
   )
 
-  const failed = results.filter(r => !r.ok)
+  const failed = settled.filter(
+    r => r.status === 'rejected' || (r.status === 'fulfilled' && !r.value.ok),
+  )
   if (failed.length > 0) {
     logger.error(`\n${failed.length} platform(s) failed:`)
-    for (const { target } of failed) {
-      logger.error(`  - ${target}`)
+    for (const r of failed) {
+      logger.error(`  - ${r.status === 'rejected' ? r.reason?.message ?? r.reason : r.value.target}`)
     }
     return false
   }