Return non-zero exit code when scan report data is not healthy. This is the expected behaviour based on our docs: https://docs.socket.dev/docs/socket-ci#non-zero-exit-code

Author: Graydon Hope

packages/cli/src/commands/scan/output-scan-report.mts

@@ -91,6 +91,11 @@ export async function outputScanReport(
     return
   }
 
+  if (!scanReport.data.healthy) {
+    // When report contains healthy: false, process should exit with non-zero code.
+    process.exitCode = 1
+  }
+
   // I don't think we emit the default error message with banner for an unhealthy report, do we?
   // if (!scanReport.data.healthy) {
   //   logger.fail(failMsgWithBadge(scanReport.message, scanReport.cause))

packages/cli/test/unit/commands/ci/handle-ci.test.mts

@@ -266,4 +266,25 @@ describe('handleCi', () => {
     expect(mockDebug).toHaveBeenCalledWith('Failed to get default org slug')
     expect(mockDebugDir).toHaveBeenCalledWith({ orgSlugCResult: error })
   })
+
+  it('sets exit code to 1 when scan report is unhealthy',
+    async () => {
+      mockGetDefaultOrgSlug.mockResolvedValue({
+        ok: true,
+        data: 'test-org',
+      })
+      
+      mockGitBranch.mockResolvedValue('main')
+      mockGetRepoName.mockResolvedValue('test-repo')
+
+      mockHandleCreateNewScan.mockImplementation(async () => {
+        process.exitCode = 1
+      })
+
+      await handleCi(false)
+
+      expect(process.exitCode).toBe(1)
+      expect(mockHandleCreateNewScan).toHaveBeenCalled()
+    }
+  )
 })