Cleanup handleCI

Author: jdalton

src/commands/ci/cmd-ci.mts

@@ -1,6 +1,6 @@
 import { logger } from '@socketsecurity/registry/lib/logger'
 
-import { handleCI } from './handle-ci.mts'
+import { handleCi } from './handle-ci.mts'
 import constants from '../../constants.mts'
 import { commonFlags } from '../../flags.mts'
 import { meowOrExit } from '../../utils/meow-with-subcommands.mts'
@@ -71,5 +71,5 @@ async function run(
     return
   }
 
-  await handleCI(Boolean(cli.flags['autoManifest']))
+  await handleCi(Boolean(cli.flags['autoManifest']))
 }

src/commands/ci/handle-ci.mts

@@ -6,9 +6,7 @@ import { getRepoName, gitBranch } from '../../utils/git.mts'
 import { serializeResultJson } from '../../utils/serialize-result-json.mts'
 import { handleCreateNewScan } from '../scan/handle-create-new-scan.mts'
 
-const { SOCKET_DEFAULT_BRANCH, SOCKET_DEFAULT_REPOSITORY } = constants
-
-export async function handleCI(autoManifest: boolean): Promise<void> {
+export async function handleCi(autoManifest: boolean): Promise<void> {
   // ci: {
   //   description: 'Alias for "report create --view --strict"',
   //     argv: ['report', 'create', '--view', '--strict']
@@ -22,23 +20,27 @@ export async function handleCI(autoManifest: boolean): Promise<void> {
   }
 
   const cwd = process.cwd()
+  // Lazily access constants.SOCKET_DEFAULT_BRANCH.
+  const branchName = (await gitBranch(cwd)) || constants.SOCKET_DEFAULT_BRANCH
+  // Lazily access constants.SOCKET_DEFAULT_REPOSITORY.
+  const repoName =
+    (await getRepoName(cwd)) || constants.SOCKET_DEFAULT_REPOSITORY
 
-  // TODO: does it makes sense to use custom branch/repo names here? probably socket.yml, right
   await handleCreateNewScan({
     autoManifest,
-    branchName: (await gitBranch(cwd)) || SOCKET_DEFAULT_BRANCH,
+    branchName,
     commitMessage: '',
     commitHash: '',
     committers: '',
-    cwd: process.cwd(),
+    cwd,
     defaultBranch: false,
     interactive: false,
     orgSlug: result.data,
     outputKind: 'json',
     // When 'pendingHead' is true, it requires 'branchName' set and 'tmp' false.
     pendingHead: true,
     pullRequest: 0,
-    repoName: (await getRepoName(cwd)) || SOCKET_DEFAULT_REPOSITORY,
+    repoName,
     readOnly: false,
     report: true,
     targets: ['.'],