fix silence bug. debug output to e2e reachability tests

Author: mtorp

src/commands/fix/handle-fix.mts

@@ -37,7 +37,10 @@ export async function convertIdsToGhsas(
   ids: string[],
   options?: ConvertIdsOptions | undefined,
 ): Promise<string[]> {
-  const { silence = false } = { __proto__: null, ...options } as ConvertIdsOptions
+  const { silence = false } = {
+    __proto__: null,
+    ...options,
+  } as ConvertIdsOptions
   debugFn('notice', `Converting ${ids.length} IDs to GHSA format`)
   debugDir('inspect', { ids })
 
@@ -96,9 +99,11 @@ export async function convertIdsToGhsas(
   }
 
   if (errors.length) {
-    logger.warn(
-      `Skipped ${errors.length} invalid IDs:\n${errors.map(e => `  - ${e}`).join('\n')}`,
-    )
+    if (!silence) {
+      logger.warn(
+        `Skipped ${errors.length} invalid IDs:\n${errors.map(e => `  - ${e}`).join('\n')}`,
+      )
+    }
     debugDir('inspect', { errors })
   }
 

src/commands/scan/cmd-scan-reach.e2e.test.mts

@@ -246,7 +246,14 @@ describe('socket scan reach (E2E tests)', async () => {
 
   describe('npm-test-workspace-mono', () => {
     cmdit(
-      ['scan', 'reach', '.', '--no-interactive', '--reach-disable-analytics'],
+      [
+        'scan',
+        'reach',
+        '.',
+        '--reach-debug',
+        '--no-interactive',
+        '--reach-disable-analytics',
+      ],
       'should run reachability analysis on workspace mono project',
       async cmd => {
         const tempFixture = await createTempFixtureCopy(
@@ -395,6 +402,7 @@ describe('socket scan reach (E2E tests)', async () => {
         'scan',
         'reach',
         '.',
+        '--reach-debug',
         '--no-interactive',
         '--reach-disable-analytics',
         '--reach-exclude-paths',
@@ -493,6 +501,7 @@ describe('socket scan reach (E2E tests)', async () => {
         'scan',
         'reach',
         'packages/package-a',
+        '--reach-debug',
         '--no-interactive',
         '--reach-disable-analytics',
       ],
@@ -598,7 +607,14 @@ describe('socket scan reach (E2E tests)', async () => {
     )
 
     cmdit(
-      ['scan', 'reach', '.', '--no-interactive', '--reach-disable-analytics'],
+      [
+        'scan',
+        'reach',
+        '.',
+        '--reach-debug',
+        '--no-interactive',
+        '--reach-disable-analytics',
+      ],
       'should use --cwd to set the working directory',
       async cmd => {
         const tempFixture = await createTempFixtureCopy(
@@ -673,6 +689,7 @@ describe('socket scan reach (E2E tests)', async () => {
         'scan',
         'reach',
         'packages/package-b',
+        '--reach-debug',
         '--no-interactive',
         '--reach-disable-analytics',
       ],
@@ -770,6 +787,7 @@ describe('socket scan reach (E2E tests)', async () => {
         'scan',
         'reach',
         '../outside-dir',
+        '--reach-debug',
         '--no-interactive',
         '--reach-disable-analytics',
       ],
@@ -822,7 +840,14 @@ describe('socket scan reach (E2E tests)', async () => {
     )
 
     cmdit(
-      ['scan', 'reach', '.', '--no-interactive', '--reach-disable-analytics'],
+      [
+        'scan',
+        'reach',
+        '.',
+        '--reach-debug',
+        '--no-interactive',
+        '--reach-disable-analytics',
+      ],
       'should write output to cwd when running from subdirectory',
       async cmd => {
         const tempFixture = await createTempFixtureCopy(
@@ -908,6 +933,7 @@ describe('socket scan reach (E2E tests)', async () => {
         'scan',
         'reach',
         '.',
+        '--reach-debug',
         '--no-interactive',
         '--reach-ecosystems',
         'pypi',
@@ -1009,6 +1035,7 @@ describe('socket scan reach (E2E tests)', async () => {
         'scan',
         'reach',
         '.',
+        '--reach-debug',
         '--no-interactive',
         '--reach-ecosystems',
         'npm',