More test fixes

Author: jdalton

src/commands/manifest/cmd-manifest-conda.mts

@@ -158,7 +158,7 @@ async function run(
       test: cli.input.length <= 1,
       message: 'Can only accept one DIR (make sure to escape spaces!)',
       pass: 'ok',
-      fail: 'received ' + cli.input.length,
+      fail: `received ${cli.input.length}`,
     },
     {
       nook: true,

src/utils/check-input.mts

@@ -1,6 +1,7 @@
 import colors from 'yoctocolors-cjs'
 
 import { logger } from '@socketsecurity/registry/lib/logger'
+import { stripAnsi } from '@socketsecurity/registry/lib/strings'
 
 import { failMsgWithBadge } from './fail-msg-with-badge.mts'
 import { serializeResultJson } from './serialize-result-json.mts'
@@ -53,7 +54,7 @@ export function checkCommandInput(
       serializeResultJson({
         ok: false,
         message: 'Input error',
-        data: msg.join('\n'),
+        data: stripAnsi(msg.join('\n')),
       }),
     )
   } else {

src/utils/serialize-result-json.mts

@@ -14,7 +14,7 @@ export function serializeResultJson(data: CResult<unknown>): string {
       debugFn('inspect', 'data:\n', data)
     }
 
-    // We should not allow the json value to be "null", or a boolean/number/string,
+    // We should not allow the JSON value to be "null", or a boolean/number/string,
     // even if they are valid "json".
     const message =
       'There was a problem converting the data set to JSON. The JSON was not an object. Please try again without --json'

test/utils.mts

@@ -64,15 +64,23 @@ export async function invokeNpm(
     return {
       status: true,
       code: 0,
-      stdout: toAsciiSafeString(normalizeLogSymbols(stripAnsi(output.stdout.trim()))),
-      stderr: toAsciiSafeString(normalizeLogSymbols(stripAnsi(output.stderr.trim()))),
+      stdout: toAsciiSafeString(
+        normalizeLogSymbols(stripAnsi(output.stdout.trim())),
+      ),
+      stderr: toAsciiSafeString(
+        normalizeLogSymbols(stripAnsi(output.stderr.trim())),
+      ),
     }
   } catch (e: unknown) {
     return {
       status: false,
       code: e?.['code'],
-      stdout: toAsciiSafeString(normalizeLogSymbols(stripAnsi(e?.['stdout']?.trim() ?? ''))),
-      stderr: toAsciiSafeString(normalizeLogSymbols(stripAnsi(e?.['stderr']?.trim() ?? ''))),
+      stdout: toAsciiSafeString(
+        normalizeLogSymbols(stripAnsi(e?.['stdout']?.trim() ?? '')),
+      ),
+      stderr: toAsciiSafeString(
+        normalizeLogSymbols(stripAnsi(e?.['stderr']?.trim() ?? '')),
+      ),
     }
   }
 }