Use parseUrl

Author: jdalton

src/shadow/npm/arborist-helpers.mts

@@ -1,5 +1,6 @@
 import { debugFn } from '@socketsecurity/registry/lib/debug'
 import { getOwn } from '@socketsecurity/registry/lib/objects'
+import { parseUrl } from '@socketsecurity/registry/lib/url'
 
 import constants from '../../constants.mts'
 import { DiffAction } from './arborist/types.mts'
@@ -15,13 +16,10 @@ import type {
 import type { Spinner } from '@socketsecurity/registry/lib/spinner'
 
 function getUrlOrigin(input: string): string {
-  try {
-    // TODO: URL.parse is available in Node 22.1.0. We can use it when we drop Node 18.
-    // https://nodejs.org/docs/latest-v22.x/api/url.html#urlparseinput-base
-    // return URL.parse(input)?.origin ?? ''
-    return new URL(input).origin ?? ''
-  } catch {}
-  return ''
+  // TODO: URL.parse is available in Node 22.1.0. We can use it when we drop Node 18.
+  // https://nodejs.org/docs/latest-v22.x/api/url.html#urlparseinput-base
+  // return URL.parse(input)?.origin ?? ''
+  return parseUrl(input)?.origin ?? ''
 }
 
 export type GetAlertsMapFromArboristOptions = {

src/utils/github.mts

@@ -14,6 +14,7 @@ import {
   writeJson,
 } from '@socketsecurity/registry/lib/fs'
 import { spawn } from '@socketsecurity/registry/lib/spawn'
+import { parseUrl } from '@socketsecurity/registry/lib/url'
 
 import constants, { UNKNOWN_ERROR } from '../constants.mts'
 
@@ -251,7 +252,14 @@ export async function setGitRemoteGithubRepoUrl(
   token: string,
   cwd = process.cwd(),
 ): Promise<boolean> {
-  const { host } = new URL(constants.ENV.GITHUB_SERVER_URL)
+  const { GITHUB_SERVER_URL } = constants.ENV
+  const urlObj = parseUrl(GITHUB_SERVER_URL)
+  const host = urlObj?.host
+  if (!host) {
+    debugFn('error', 'invalid: GITHUB_SERVER_URL env var')
+    debugDir('inspect', { GITHUB_SERVER_URL })
+    return false
+  }
   const url = `https://x-access-token:${token}@${host}/${owner}/${repo}`
   const stdioIgnoreOptions: SpawnOptions = {
     cwd,