fix(test): replace vi.mock('node:fs') in output-cmd-json test

Author: jdalton

packages/cli/src/commands/json/output-cmd-json.mts

@@ -1,4 +1,4 @@
-import { existsSync } from 'node:fs'
+import fs from 'node:fs'
 import path from 'node:path'
 
 import { safeReadFileSync, safeStatsSync } from '@socketsecurity/lib/fs'
@@ -16,7 +16,7 @@ export async function outputCmdJson(cwd: string) {
   const sockJsonPath = path.join(cwd, SOCKET_JSON)
   const tildeSockJsonPath = VITEST ? REDACTED : tildify(sockJsonPath)
 
-  if (!existsSync(sockJsonPath)) {
+  if (!fs.existsSync(sockJsonPath)) {
     logger.fail(`Not found: ${tildeSockJsonPath}`)
     process.exitCode = 1
     return

packages/cli/test/unit/commands/json/output-cmd-json.test.mts

@@ -1,23 +1,11 @@
 /**
- * Unit tests for json command output.
- *
- * Purpose:
- * Tests the output-cmd-json utility for displaying socket.json contents.
- *
- * Test Coverage:
- * - File not found handling
- * - Non-file (directory) handling
- * - Successful file reading
- *
- * Related Files:
- * - commands/json/output-cmd-json.mts (implementation)
+ * @fileoverview Unit tests for json command output.
  */
 
-import path from 'node:path'
+import fs from 'node:fs'
 
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
-// Mock dependencies.
 const mockLogger = vi.hoisted(() => ({
   error: vi.fn(),
   fail: vi.fn(),
@@ -30,48 +18,42 @@ vi.mock('@socketsecurity/lib/logger', () => ({
   getDefaultLogger: () => mockLogger,
 }))
 
-vi.mock('node:fs', async () => {
-  const actual = await vi.importActual('node:fs')
-  return {
-    ...actual,
-    existsSync: vi.fn(),
-  }
-})
+const mockSafeReadFileSync = vi.fn()
+const mockSafeStatsSync = vi.fn()
 
 vi.mock('@socketsecurity/lib/fs', () => ({
-  safeReadFileSync: vi.fn(),
-  safeStatsSync: vi.fn(),
+  safeReadFileSync: (...args: unknown[]) => mockSafeReadFileSync(...args),
+  safeStatsSync: (...args: unknown[]) => mockSafeStatsSync(...args),
 }))
 
-import { existsSync } from 'node:fs'
-
-import { safeReadFileSync, safeStatsSync } from '@socketsecurity/lib/fs'
-
 import { outputCmdJson } from '../../../../src/commands/json/output-cmd-json.mts'
 
 describe('output-cmd-json', () => {
   const originalExitCode = process.exitCode
+  let existsSyncSpy: ReturnType<typeof vi.spyOn>
 
   beforeEach(() => {
     vi.clearAllMocks()
     process.exitCode = undefined
+    existsSyncSpy = vi.spyOn(fs, 'existsSync')
   })
 
   afterEach(() => {
+    existsSyncSpy.mockRestore()
     process.exitCode = originalExitCode
   })
 
   describe('outputCmdJson', () => {
     it('logs info about target cwd', async () => {
-      vi.mocked(existsSync).mockReturnValue(false)
+      existsSyncSpy.mockReturnValue(false)
 
       await outputCmdJson('/test/path')
 
       expect(mockLogger.info).toHaveBeenCalledWith('Target cwd:', expect.any(String))
     })
 
     it('handles socket.json not found', async () => {
-      vi.mocked(existsSync).mockReturnValue(false)
+      existsSyncSpy.mockReturnValue(false)
 
       await outputCmdJson('/test/path')
 
@@ -82,10 +64,10 @@ describe('output-cmd-json', () => {
     })
 
     it('handles non-file (directory) path', async () => {
-      vi.mocked(existsSync).mockReturnValue(true)
-      vi.mocked(safeStatsSync).mockReturnValue({
+      existsSyncSpy.mockReturnValue(true)
+      mockSafeStatsSync.mockReturnValue({
         isFile: () => false,
-      } as any)
+      })
 
       await outputCmdJson('/test/path')
 
@@ -97,11 +79,11 @@ describe('output-cmd-json', () => {
 
     it('successfully reads and outputs socket.json contents', async () => {
       const mockContent = JSON.stringify({ version: '1.0.0' }, null, 2)
-      vi.mocked(existsSync).mockReturnValue(true)
-      vi.mocked(safeStatsSync).mockReturnValue({
+      existsSyncSpy.mockReturnValue(true)
+      mockSafeStatsSync.mockReturnValue({
         isFile: () => true,
-      } as any)
-      vi.mocked(safeReadFileSync).mockReturnValue(mockContent)
+      })
+      mockSafeReadFileSync.mockReturnValue(mockContent)
 
       await outputCmdJson('/test/path')
 
@@ -113,8 +95,8 @@ describe('output-cmd-json', () => {
     })
 
     it('handles null safeStatsSync result', async () => {
-      vi.mocked(existsSync).mockReturnValue(true)
-      vi.mocked(safeStatsSync).mockReturnValue(null)
+      existsSyncSpy.mockReturnValue(true)
+      mockSafeStatsSync.mockReturnValue(null)
 
       await outputCmdJson('/test/path')