Fix Windows CI tests

Author: jdalton

src/commands/fix/cmd-fix.test.mts

@@ -62,10 +62,6 @@ describe('socket fix', async () => {
     'should require args with just dry-run',
     async cmd => {
       const { code, stderr, stdout } = await invokeNpm(entryPath, cmd)
-      expect(stdout).toMatchInlineSnapshot(`
-        "\\x1b[34mi\\x1b[39m Fixing packages for npm
-        [DryRun]: Not saving"
-      `)
       expect(`\n   ${stderr}`).toMatchInlineSnapshot(`
         "
            _____         _       _        /---------------
@@ -75,6 +71,10 @@ describe('socket fix', async () => {
 
         \\x1b[33m\\u203c\\x1b[39m socket fix: Package package-lock.json found at <redacted>"
       `)
+      expect(stdout).toMatchInlineSnapshot(`
+        "\\x1b[34mi\\x1b[39m Fixing packages for npm
+        [DryRun]: Not saving"
+      `)
       expect(code, 'dry-run should exit with code 0 if input ok').toBe(0)
     }
   )

src/utils/package-environment.mts

@@ -6,6 +6,7 @@ import semver from 'semver'
 import which from 'which'
 
 import { parse as parseBunLockb } from '@socketregistry/hyrious__bun.lockb/index.cjs'
+import { debugLog } from '@socketsecurity/registry/lib/debug'
 import { Logger } from '@socketsecurity/registry/lib/logger'
 import { readPackageJson } from '@socketsecurity/registry/lib/packages'
 import { naturalCompare } from '@socketsecurity/registry/lib/sorts'
@@ -50,6 +51,10 @@ const binByAgent = new Map<Agent, string>([
 
 async function getAgentExecPath(agent: Agent): Promise<string> {
   const binName = binByAgent.get(agent)!
+  if (binName === NPM) {
+    // Lazily access constants.npmExecPath.
+    return constants.npmExecPath
+  }
   return (await which(binName, { nothrow: true })) ?? binName
 }
 
@@ -67,8 +72,8 @@ async function getAgentVersion(
         // All package managers support the "--version" flag.
         (await spawn(agentExecPath, ['--version'], { cwd })).stdout
       ) ?? undefined
-  } catch (e){
-    console.log(e)
+  } catch (e) {
+    debugLog('getAgentVersion error:\n', e)
   }
   return result
 }
@@ -399,7 +404,6 @@ export async function detectAndValidatePackageEnvironment(
   const agentVersion = details.agentVersion ?? 'unknown'
   if (!details.agentSupported) {
     const minVersion = constants.minimumVersionByAgent.get(agent)!
-    console.dir({ details }, { depth: 999 })
     logger?.fail(
       cmdPrefixMessage(
         cmdName,