Fix tests to include proper testing for output report generation

Author: Graydon Hope

packages/cli/test/unit/commands/scan/output-scan-report.test.mts

@@ -19,16 +19,45 @@
  * - src/commands/outputScanReport.mts (implementation)
  */
 
-import { describe, expect, it } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
 import {
+  outputScanReport,
   toJsonReport,
   toMarkdownReport,
 } from '../../../../src/commands/scan/output-scan-report.mts'
 import { SOCKET_WEBSITE_URL } from '../../../../src/constants/socket.mts'
 
 import type { ScanReport } from '../../../../src/commands/scan/generate-report.mts'
 
+const { mockGenerateReport, mockLogger, mockGetSpinner } = vi.hoisted(() => ({
+  mockGenerateReport: vi.fn(),
+  mockLogger: { log: vi.fn(), fail: vi.fn(), dir: vi.fn() },
+  mockGetSpinner: vi.fn(() => ({
+    start: vi.fn(),
+    successAndStop: vi.fn(),
+  })),
+}))
+
+vi.mock('../../../../src/commands/scan/generate-report.mts', async () => {
+  const actual =
+    await vi.importActual<
+      typeof import('../../../../src/commands/scan/generate-report.mts')
+    >('../../../../src/commands/scan/generate-report.mts')
+  return {
+    ...actual,
+    generateReport: mockGenerateReport,
+  }
+})
+
+vi.mock('@socketsecurity/lib-internal/logger', () => ({
+  getDefaultLogger: () => mockLogger,
+}))
+
+vi.mock('@socketsecurity/lib-internal/constants/process', () => ({
+  getSpinner: mockGetSpinner,
+}))
+
 describe('output-scan-report', () => {
   describe('toJsonReport', () => {
     it('should be able to generate a healthy json report', () => {
@@ -159,6 +188,71 @@ describe('output-scan-report', () => {
       `)
     })
   })
+
+  describe('outputScanReport exit code behavior', () => {
+    const originalExitCode = process.exitCode
+
+    beforeEach(() => {
+      process.exitCode = undefined
+      vi.clearAllMocks()
+    })
+
+    afterEach(() => {
+      process.exitCode = originalExitCode
+    })
+
+    it('sets exit code to 1 when report is unhealthy', async () => {
+      mockGenerateReport.mockReturnValue({
+        ok: true,
+        data: getUnhealthyReport(),
+      })
+
+      await outputScanReport(
+        {
+          ok: true,
+          data: { scan: [], securityPolicy: {} },
+        } as any,
+        {
+          orgSlug: 'test-org',
+          scanId: 'test-scan',
+          includeLicensePolicy: false,
+          outputKind: 'json',
+          filepath: '-',
+          fold: 'none',
+          reportLevel: 'error',
+          short: false,
+        },
+      )
+
+      expect(process.exitCode).toBe(1)
+    })
+
+    it('does not set exit code when report is healthy', async () => {
+      mockGenerateReport.mockReturnValue({
+        ok: true,
+        data: getHealthyReport(),
+      })
+
+      await outputScanReport(
+        {
+          ok: true,
+          data: { scan: [], securityPolicy: {} },
+        } as any,
+        {
+          orgSlug: 'test-org',
+          scanId: 'test-scan',
+          includeLicensePolicy: false,
+          outputKind: 'json',
+          filepath: '-',
+          fold: 'none',
+          reportLevel: 'error',
+          short: false,
+        },
+      )
+
+      expect(process.exitCode).toBeUndefined()
+    })
+  })
 })
 
 function getHealthyReport(): ScanReport {