test: use os.tmpdir() instead of hardcoded /tmp paths

Replace hardcoded /tmp paths with os.tmpdir() for cross-platform compatibility.
Fixes test failures on Windows where /tmp directory doesn't exist.

Author: jdalton

src/commands/analytics/handle-analytics.test.mts

@@ -1,3 +1,6 @@
+import os from 'node:os'
+import path from 'node:path'
+
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 import { handleAnalytics } from './handle-analytics.mts'
@@ -14,6 +17,8 @@ vi.mock('./output-analytics.mts', () => ({
 }))
 
 describe('handleAnalytics', () => {
+  const tmpAnalyticsPath = path.join(os.tmpdir(), 'analytics.json')
+
   beforeEach(() => {
     vi.clearAllMocks()
   })
@@ -29,7 +34,7 @@ describe('handleAnalytics', () => {
     })
 
     await handleAnalytics({
-      filepath: '/tmp/analytics.json',
+      filepath: tmpAnalyticsPath,
       outputKind: 'json',
       repo: '',
       scope: 'org',
@@ -40,7 +45,7 @@ describe('handleAnalytics', () => {
     expect(outputAnalytics).toHaveBeenCalledWith(
       { ok: true, data: mockData },
       {
-        filepath: '/tmp/analytics.json',
+        filepath: tmpAnalyticsPath,
         outputKind: 'json',
         repo: '',
         scope: 'org',
@@ -62,7 +67,7 @@ describe('handleAnalytics', () => {
     })
 
     await handleAnalytics({
-      filepath: '/tmp/analytics.json',
+      filepath: tmpAnalyticsPath,
       outputKind: 'json',
       repo: 'test-repo',
       scope: 'repo',
@@ -73,7 +78,7 @@ describe('handleAnalytics', () => {
     expect(outputAnalytics).toHaveBeenCalledWith(
       { ok: true, data: mockData },
       {
-        filepath: '/tmp/analytics.json',
+        filepath: tmpAnalyticsPath,
         outputKind: 'json',
         repo: 'test-repo',
         scope: 'repo',
@@ -86,7 +91,7 @@ describe('handleAnalytics', () => {
     const { outputAnalytics } = await import('./output-analytics.mts')
 
     await handleAnalytics({
-      filepath: '/tmp/analytics.json',
+      filepath: tmpAnalyticsPath,
       outputKind: 'json',
       repo: '',
       scope: 'repo',
@@ -99,7 +104,7 @@ describe('handleAnalytics', () => {
         message: 'Missing repository name in command',
       },
       {
-        filepath: '/tmp/analytics.json',
+        filepath: tmpAnalyticsPath,
         outputKind: 'json',
         repo: '',
         scope: 'repo',
@@ -118,7 +123,7 @@ describe('handleAnalytics', () => {
     })
 
     await handleAnalytics({
-      filepath: '/tmp/analytics.json',
+      filepath: tmpAnalyticsPath,
       outputKind: 'json',
       repo: '',
       scope: 'org',
@@ -148,7 +153,7 @@ describe('handleAnalytics', () => {
     })
 
     await handleAnalytics({
-      filepath: '/tmp/analytics.json',
+      filepath: tmpAnalyticsPath,
       outputKind: 'json',
       repo: 'test-repo',
       scope: 'repo',
@@ -176,7 +181,7 @@ describe('handleAnalytics', () => {
     })
 
     await handleAnalytics({
-      filepath: '/tmp/analytics.json',
+      filepath: tmpAnalyticsPath,
       outputKind: 'json',
       repo: '',
       scope: 'org',

src/utils/dlx-detection.test.mts

@@ -1,3 +1,4 @@
+import os from 'node:os'
 import path from 'node:path'
 
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
@@ -142,7 +143,7 @@ describe('dlx-detection', () => {
 
     it('skips when cwd contains dlx- prefix', () => {
       const result = shouldSkipShadow('/usr/local/bin/pnpm', {
-        cwd: '/tmp/dlx-socket-cli-12345/node_modules/.bin',
+        cwd: path.join(os.tmpdir(), 'dlx-socket-cli-12345/node_modules/.bin'),
       })
       expect(result).toBe(true)
     })

src/utils/tildify.test.mts

@@ -1,3 +1,4 @@
+import os from 'node:os'
 import path from 'node:path'
 
 import { describe, expect, it, vi } from 'vitest'
@@ -54,7 +55,8 @@ describe('tildify utilities', () => {
 
     it('leaves non-home paths unchanged', () => {
       expect(tildify('/var/log/system.log')).toBe('/var/log/system.log')
-      expect(tildify('/tmp/file.txt')).toBe('/tmp/file.txt')
+      const tmpPath = path.join(os.tmpdir(), 'file.txt')
+      expect(tildify(tmpPath)).toBe(tmpPath)
       expect(tildify('./relative/path')).toBe('./relative/path')
       expect(tildify('../parent/path')).toBe('../parent/path')
     })