Use shell: true for WIN32

Author: jdalton

src/commands/optimize/ls-by-agent.mts

@@ -47,7 +47,13 @@ function parsableToQueryStdout(stdout: string) {
 async function npmQuery(npmExecPath: string, cwd: string): Promise<string> {
   let stdout = ''
   try {
-    stdout = (await spawn(npmExecPath, ['query', ':not(.dev)'], { cwd })).stdout
+    stdout = (
+      await spawn(npmExecPath, ['query', ':not(.dev)'], {
+        cwd,
+        // Lazily access constants.WIN32.
+        shell: constants.WIN32
+      })
+    ).stdout
   } catch {}
   return cleanupQueryStdout(stdout)
 }
@@ -57,7 +63,11 @@ async function lsBun(pkgEnvDetails: EnvDetails, cwd: string): Promise<string> {
     // Bun does not support filtering by production packages yet.
     // https://github.com/oven-sh/bun/issues/8283
     return (
-      await spawn(pkgEnvDetails.agentExecPath, ['pm', 'ls', '--all'], { cwd })
+      await spawn(pkgEnvDetails.agentExecPath, ['pm', 'ls', '--all'], {
+        cwd,
+        // Lazily access constants.WIN32.
+        shell: constants.WIN32
+      })
     ).stdout
   } catch {}
   return ''
@@ -87,7 +97,11 @@ async function lsPnpm(
         // Pnpm uses the alternative spelling of parsable.
         // https://en.wiktionary.org/wiki/parsable
         ['ls', '--parseable', '--prod', '--depth', 'Infinity'],
-        { cwd }
+        {
+          cwd,
+          // Lazily access constants.WIN32.
+          shell: constants.WIN32
+        }
       )
     ).stdout
   } catch {}
@@ -103,7 +117,9 @@ async function lsVlt(pkgEnvDetails: EnvDetails, cwd: string): Promise<string> {
         pkgEnvDetails.agentExecPath,
         ['ls', '--view', 'human', ':not(.dev)'],
         {
-          cwd
+          cwd,
+          // Lazily access constants.WIN32.
+          shell: constants.WIN32
         }
       )
     ).stdout
@@ -124,7 +140,9 @@ async function lsYarnBerry(
           pkgEnvDetails.agentExecPath,
           ['info', '--recursive', '--name-only'],
           {
-            cwd
+            cwd,
+            // Lazily access constants.WIN32.
+            shell: constants.WIN32
           }
         )
       ).stdout.trim()
@@ -143,7 +161,11 @@ async function lsYarnClassic(
     // > Fix: Excludes dev dependencies from the yarn list output when the
     //   environment is production
     return (
-      await spawn(pkgEnvDetails.agentExecPath, ['list', '--prod'], { cwd })
+      await spawn(pkgEnvDetails.agentExecPath, ['list', '--prod'], {
+        cwd,
+        // Lazily access constants.WIN32.
+        shell: constants.WIN32
+      })
     ).stdout.trim()
   } catch {}
   return ''

src/utils/package-environment.mts

@@ -70,7 +70,13 @@ async function getAgentVersion(
       // and tildes (~).
       semver.coerce(
         // All package managers support the "--version" flag.
-        (await spawn(agentExecPath, ['--version'], { cwd })).stdout
+        (
+          await spawn(agentExecPath, ['--version'], {
+            cwd,
+            // Lazily access constants.WIN32.
+            shell: constants.WIN32
+          })
+        ).stdout
       ) ?? undefined
   } catch (e) {
     debugLog('getAgentVersion error:\n', e)
@@ -103,6 +109,11 @@ const LOCKS: Record<string, Agent> = {
 type ReadLockFile =
   | ((lockPath: string) => Promise<string | undefined>)
   | ((lockPath: string, agentExecPath: string) => Promise<string | undefined>)
+  | ((
+      lockPath: string,
+      agentExecPath: string,
+      cwd: string
+    ) => Promise<string | undefined>)
 
 const readLockFileByAgent: Map<Agent, ReadLockFile> = (() => {
   function wrapReader<T extends (...args: any[]) => Promise<any>>(
@@ -125,25 +136,37 @@ const readLockFileByAgent: Map<Agent, ReadLockFile> = (() => {
   return new Map([
     [
       BUN,
-      wrapReader(async (lockPath: string, agentExecPath: string) => {
-        const ext = path.extname(lockPath)
-        if (ext === LOCK_EXT) {
-          return await defaultReader(lockPath)
-        }
-        if (ext === BINARY_LOCK_EXT) {
-          const lockBuffer = await binaryReader(lockPath)
-          if (lockBuffer) {
-            try {
-              return parseBunLockb(lockBuffer)
-            } catch {}
+      wrapReader(
+        async (
+          lockPath: string,
+          agentExecPath: string,
+          cwd = process.cwd()
+        ) => {
+          const ext = path.extname(lockPath)
+          if (ext === LOCK_EXT) {
+            return await defaultReader(lockPath)
+          }
+          if (ext === BINARY_LOCK_EXT) {
+            const lockBuffer = await binaryReader(lockPath)
+            if (lockBuffer) {
+              try {
+                return parseBunLockb(lockBuffer)
+              } catch {}
+            }
+            // To print a Yarn lockfile to your console without writing it to disk
+            // use `bun bun.lockb`.
+            // https://bun.sh/guides/install/yarnlock
+            return (
+              await spawn(agentExecPath, [lockPath], {
+                cwd,
+                // Lazily access constants.WIN32.
+                shell: constants.WIN32
+              })
+            ).stdout.trim()
           }
-          // To print a Yarn lockfile to your console without writing it to disk
-          // use `bun bun.lockb`.
-          // https://bun.sh/guides/install/yarnlock
-          return (await spawn(agentExecPath, [lockPath])).stdout.trim()
+          return undefined
         }
-        return undefined
-      })
+      )
     ],
     [NPM, defaultReader],
     [PNPM, defaultReader],
@@ -314,7 +337,7 @@ export async function detectPackageEnvironment({
     }
     lockSrc =
       typeof lockPath === 'string'
-        ? await readLockFileByAgent.get(agent)!(lockPath, agentExecPath)
+        ? await readLockFileByAgent.get(agent)!(lockPath, agentExecPath, cwd)
         : undefined
   } else {
     lockName = undefined