test(dlx): add binaryName assertions and fix lenient coana test

Unit test improvements:
- Add binaryName assertions for all resolve functions (coana, cdxgen, synp)
- Update tests to use 'details' property instead of deprecated 'packageSpec'
- Verify binary names are correct when package name differs from binary name

E2E test improvements:
- Remove lenient error handling in coana test that was masking failures
- Make coana test require success instead of allowing failures
- Add new test verifying binary name resolution from package name
- Fix import paths to use correct module locations

These changes ensure tests catch issues where binaryName is missing or
incorrect, preventing bugs like the @coana-tech/cli resolution failure.

Author: jdalton

packages/cli/src/utils/dlx/resolve-binary.test.mts

@@ -44,8 +44,9 @@ describe('resolve-binary', () => {
       >
 
       expect(result.type).toBe('dlx')
-      expect(result.packageSpec.name).toBe('@coana-tech/cli')
-      expect(result.packageSpec.version).toContain('~')
+      expect(result.details.name).toBe('@coana-tech/cli')
+      expect(result.details.version).toContain('~')
+      expect(result.details.binaryName).toBe('coana')
     })
 
     it('should prefer local path over dlx when both available', () => {
@@ -82,7 +83,8 @@ describe('resolve-binary', () => {
       >
 
       expect(result.type).toBe('dlx')
-      expect(result.packageSpec.name).toBe('@cyclonedx/cdxgen')
+      expect(result.details.name).toBe('@cyclonedx/cdxgen')
+      expect(result.details.binaryName).toBe('cdxgen')
     })
   })
 
@@ -133,7 +135,8 @@ describe('resolve-binary', () => {
       const result = resolveSynp() as Extract<BinaryResolution, { type: 'dlx' }>
 
       expect(result.type).toBe('dlx')
-      expect(result.packageSpec.name).toBe('synp')
+      expect(result.details.name).toBe('synp')
+      expect(result.details.binaryName).toBe('synp')
     })
 
     it('should return dlx even if environment variables are set', () => {
@@ -142,7 +145,8 @@ describe('resolve-binary', () => {
       const result = resolveSynp() as Extract<BinaryResolution, { type: 'dlx' }>
 
       expect(result.type).toBe('dlx')
-      expect(result.packageSpec.name).toBe('synp')
+      expect(result.details.name).toBe('synp')
+      expect(result.details.binaryName).toBe('synp')
     })
   })
 

packages/cli/test/e2e/dlx-spawn.e2e.test.mts

@@ -140,42 +140,51 @@ describe('dlx e2e tests', () => {
 
   describe('spawnCoanaDlx e2e tests', () => {
     it.skipIf(!ENV.RUN_E2E_TESTS || !hasAuth)(
-      'executes coana-tech/cli via dlx',
+      'executes coana-tech/cli via dlx with correct binary name',
       async () => {
-        const { spawnCoanaDlx } = await import('./spawn.mts')
+        const { spawnCoanaDlx } = await import('../../src/utils/dlx/spawn.mts')
         const result = await spawnCoanaDlx(['--help'])
 
-        // Coana might fail due to network issues or package availability
+        // Coana should succeed - if it fails, it indicates a real issue.
         expect(result).toBeDefined()
-        expect(typeof result.ok).toBe('boolean')
+        expect(result.ok).toBe(true)
 
         if (result.ok && result.data) {
+          // Verify we got output from coana binary.
           expect(result.data).toContain('coana')
-        } else if (!result.ok) {
-          // Log the error for debugging but don't fail the test
-          console.log(
-            'Coana failed (expected in some environments):',
-            result.message,
-          )
-          expect(result.message).toBeDefined()
+        } else {
+          // If coana fails, the test should fail to catch real issues.
+          throw new Error(`Coana execution failed: ${result.message}`)
         }
       },
       30000,
     )
 
     it.skipIf(!ENV.RUN_E2E_TESTS || !hasAuth)(
-      'handles error from spawn',
+      'verifies coana binary is correctly resolved from package name',
       async () => {
-        const { spawnCoanaDlx } = await import('./spawn.mts')
-        // Pass invalid args to trigger an error.
-        const result = await spawnCoanaDlx([
-          '--invalid-flag-that-does-not-exist',
-        ])
+        const { spawnCoanaDlx } = await import('../../src/utils/dlx/spawn.mts')
+        const { resolveCoana } = await import(
+          '../../src/utils/dlx/resolve-binary.mts'
+        )
+
+        // Verify the resolution includes correct binary name.
+        const resolution = resolveCoana()
+        if (resolution.type === 'dlx') {
+          expect(resolution.details.name).toBe('@coana-tech/cli')
+          expect(resolution.details.binaryName).toBe('coana')
+        }
+
+        // Verify execution works with resolved binary name.
+        const result = await spawnCoanaDlx(['--version'])
 
-        // The command might still succeed if the tool ignores unknown flags.
-        // Just verify we get a result.
         expect(result).toBeDefined()
-        expect(typeof result.ok).toBe('boolean')
+        expect(result.ok).toBe(true)
+
+        if (result.ok && result.data) {
+          // Version output should contain coana information.
+          expect(result.data).toBeTruthy()
+        }
       },
       30000,
     )